From: Greg KH <gregkh@linuxfoundation.org>
To: Chandra S Gorentla <csgorentla@gmail.com>
Cc: rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com
Subject: Re: [PATCH] staging: wilc1000: Set all options in region debugfs file
Date: Tue, 18 Aug 2015 20:01:00 -0700 [thread overview]
Message-ID: <20150819030100.GE4588@kroah.com> (raw)
In-Reply-To: <1439917337-18473-1-git-send-email-csgorentla@gmail.com>
On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote:
> This patch allows setting all options in the module's debug region
> options file 'wilc_debug_region'. This functionality allows the user
> to enable logging from all regions (initialization, locks, firmware
> etc.) of the driver. Logging from the following regions is enabled
> during the driver initialization:
>
> INIT_DBG, GENERIC_DBG, CFG80211_DBG, FIRM_DBG and HOSTAPD_DBG
>
> Before this change, the numerical value set is equal first byte of
> input minus 0x30 (ASCII value of '0'). Because of this, after a write
> to this debugfs file, it is difficult to predict the regions on which
> logging is enabled.
>
> The DBG_REGION_ALL now includes 3 additional regions TCP_ENH, SPIN_DEBUG
> and FIRM_DBG.
Why did you add these extra ones?
All of this should eventually just be deleted, as network drivers need
to use the networking driver debug interfaces, not their own crazy ones.
thanks,
greg k-h
next prev parent reply other threads:[~2015-08-19 3:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 17:02 [PATCH] staging: wilc1000: Set all options in region debugfs file Chandra S Gorentla
2015-08-19 3:01 ` Greg KH [this message]
2015-08-19 12:30 ` Chandra Gorentla
2015-08-19 14:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819030100.GE4588@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris.park@atmel.com \
--cc=csgorentla@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).