From: Kalle Valo <kvalo@codeaurora.org>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org,
Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [v2] ath9k_htc: do ani shortcalibratio if we got -ETIMEDOUT
Date: Tue, 25 Aug 2015 12:10:25 +0000 (UTC) [thread overview]
Message-ID: <20150825121025.33373140271@smtp.codeaurora.org> (raw)
In-Reply-To: <1439529399-3094-1-git-send-email-linux@rempel-privat.de>
> current code will handle -ETIMEDOUT as success which is probalbly wrong.
>
> According to this comment I assume it is safe to handle -ETIMEDOUT as false:
> drivers/net/wireless/ath/ath9k/calib.c
> 290 /*
> 291 * We timed out waiting for the noisefloor to load, probably due to an
> 292 * in-progress rx. Simply return here and allow the load plenty of time
> 293 * to complete before the next calibration interval. We need to avoid
> 294 * trying to load -50 (which happens below) while the previous load is
> 295 * still in progress as this can cause rx deafness. Instead by returning
> 296 * here, the baseband nf cal will just be capped by our present
> 297 * noisefloor until the next calibration timer.
> 298 */
>
> Since no other error wariants are present, this patch is checking only
> for (ret <= 0).
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2015-08-25 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150811214324.GA30816@mwanda>
2015-08-13 18:21 ` [PATCH] ath9k_htc: do ani shortcalibratio if we got -ETIMEDOUT Oleksij Rempel
2015-08-14 5:10 ` [ath9k-devel] " Oleksij Rempel
2015-08-14 5:16 ` [PATCH v2] " Oleksij Rempel
2015-08-25 12:10 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825121025.33373140271@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).