From: Greg KH <gregkh@linuxfoundation.org>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: rachel.kim@atmel.com, devel@driverdev.osuosl.org,
chris.park@atmel.com, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com
Subject: Re: [PATCH 01/30] staging: wilc1000: rename WILC_WFI_CfgSetChannel
Date: Wed, 9 Sep 2015 11:15:58 -0700 [thread overview]
Message-ID: <20150909181558.GA30416@kroah.com> (raw)
In-Reply-To: <1441727767-26026-1-git-send-email-chaehyun.lim@gmail.com>
On Wed, Sep 09, 2015 at 12:55:38AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_cfg80211_set_monitor_channel to avoid CamelCase.
Like was said, this is now longer, how about something "simple" like
wilc_set_channel()?
Actually, as this is a static function, set_channel() would work, no
need to prefix static functions as it's obvious it is "wilc".
Same for all of the other patches in this series, can you please redo
them to be simpler?
thanks,
greg k-h
prev parent reply other threads:[~2015-09-09 19:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 15:55 [PATCH 01/30] staging: wilc1000: rename WILC_WFI_CfgSetChannel Chaehyun Lim
2015-09-08 15:55 ` [PATCH 02/30] staging: wilc1000: rename WILC_WFI_CfgScan Chaehyun Lim
2015-09-08 15:55 ` [PATCH 03/30] staging: wilc1000: rename WILC_WFI_CfgConnect Chaehyun Lim
2015-09-08 15:55 ` [PATCH 04/30] staging: wilc1000: rename WILC_WFI_add_key Chaehyun Lim
2015-09-08 15:55 ` [PATCH 05/30] staging: wilc1000: rename WILC_WFI_del_key Chaehyun Lim
2015-09-08 15:55 ` [PATCH 06/30] staging: wilc1000: rename WILC_WFI_get_key Chaehyun Lim
2015-09-08 15:55 ` [PATCH 07/30] staging: wilc1000: rename WILC_WFI_set_default_key Chaehyun Lim
2015-09-08 15:55 ` [PATCH 08/30] staging: wilc1000: rename WILC_WFI_add_virt_intf Chaehyun Lim
2015-09-08 15:55 ` [PATCH 09/30] staging: wilc1000: rename WILC_WFI_del_virt_intf Chaehyun Lim
2015-09-08 15:55 ` [PATCH 10/30] staging: wilc1000: rename WILC_WFI_change_virt_intf Chaehyun Lim
2015-09-08 15:55 ` [PATCH 11/30] staging: wilc1000: rename WILC_WFI_start_ap Chaehyun Lim
2015-09-08 15:55 ` [PATCH 12/30] staging: wilc1000: rename WILC_WFI_change_beacon Chaehyun Lim
2015-09-08 15:55 ` [PATCH 13/30] staging: wilc1000: rename WILC_WFI_stop_ap Chaehyun Lim
2015-09-08 15:55 ` [PATCH 14/30] staging: wilc1000: rename WILC_WFI_add_station Chaehyun Lim
2015-09-08 15:55 ` [PATCH 15/30] staging: wilc1000: rename WILC_WFI_del_station Chaehyun Lim
2015-09-08 15:55 ` [PATCH 16/30] staging: wilc1000: rename WILC_WFI_change_station Chaehyun Lim
2015-09-08 15:55 ` [PATCH 17/30] staging: wilc1000: rename WILC_WFI_get_station Chaehyun Lim
2015-09-08 15:55 ` [PATCH 18/30] staging: wilc1000: rename WILC_WFI_dump_station Chaehyun Lim
2015-09-08 15:55 ` [PATCH 19/30] staging: wilc1000: rename WILC_WFI_change_bss Chaehyun Lim
2015-09-08 15:55 ` [PATCH 20/30] staging: wilc1000: rename WILC_WFI_set_wiphy_params Chaehyun Lim
2015-09-08 15:55 ` [PATCH 21/30] staging: wilc1000: rename WILC_WFI_set_pmksa Chaehyun Lim
2015-09-08 15:55 ` [PATCH 22/30] staging: wilc1000: rename WILC_WFI_del_pmksa Chaehyun Lim
2015-09-08 15:56 ` [PATCH 23/30] staging: wilc1000: rename WILC_WFI_flush_pmksa Chaehyun Lim
2015-09-08 15:56 ` [PATCH 24/30] staging: wilc1000: rename WILC_WFI_remain_on_channel Chaehyun Lim
2015-09-08 15:56 ` [PATCH 25/30] staging: wilc1000: rename WILC_WFI_cancel_remain_on_channel Chaehyun Lim
2015-09-08 15:56 ` [PATCH 26/30] staging: wilc1000: rename WILC_WFI_mgmt_tx_cancel_wait Chaehyun Lim
2015-09-08 15:56 ` [PATCH 27/30] staging: wilc1000: rename WILC_WFI_mgmt_tx Chaehyun Lim
2015-09-08 15:56 ` [PATCH 28/30] staging: wilc1000: rename WILC_WFI_frame_register Chaehyun Lim
2015-09-08 15:56 ` [PATCH 29/30] staging: wilc1000: rename WILC_WFI_set_power_mgmt Chaehyun Lim
2015-09-08 15:56 ` [PATCH 30/30] staging: wilc1000: rename WILC_WFI_set_cqm_rssi_config Chaehyun Lim
2015-09-08 15:59 ` [PATCH 01/30] staging: wilc1000: rename WILC_WFI_CfgSetChannel Johannes Berg
2015-09-09 18:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909181558.GA30416@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).