Re: [PATCH V2 01/31] staging: wilc1000: rename WILC_WFI_CfgSetChannel

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Sep 11, 2015 at 04:14:00AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_set_channel to avoid CamelCase.
> 
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
> V2: to make function name simple
> 
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index cf76a33..3149fd8 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -677,7 +677,7 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent,
>  
>  
>  /**
> - *  @brief      WILC_WFI_CfgSetChannel
> + *  @brief      wilc_set_channel
>   *  @details    Set channel for a given wireless interface. Some devices
>   *                      may support multi-channel operation (by channel hopping) so cfg80211
>   *                      doesn't verify much. Note, however, that the passed netdev may be
> @@ -689,8 +689,8 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent,
>   *  @date	01 MAR 2012
>   *  @version	1.0
>   */
> -static int WILC_WFI_CfgSetChannel(struct wiphy *wiphy,
> -				  struct cfg80211_chan_def *chandef)
> +static int wilc_set_channel(struct wiphy *wiphy,
> +			    struct cfg80211_chan_def *chandef)

static functions do not need a "wilc_" prefix.  Just name it
"set_channel()"

Can you redo this series based on that, rebase on my staging-testing git
branch as things are changing fast in this driver, and then resend?

thanks,

greg k-h