From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Staging: wilc1000: wilc_wfi_cfgoperations.c: replace memset(x,0,ETH_ALEN)
Date: Sat, 12 Sep 2015 08:48:41 -0700 [thread overview]
Message-ID: <20150912154841.GB29944@kroah.com> (raw)
In-Reply-To: <1442036259-2693-1-git-send-email-shraddha.6596@gmail.com>
On Sat, Sep 12, 2015 at 11:07:39AM +0530, Shraddha Barke wrote:
> eth_zero_addr() is a wrapper function for memset if 0 is going to
> be assigned to a mac address. The aforementioned function replaces
> memset.
>
> Changes were done using Coccinelle
>
> @eth_zero_addr@
> expression e;
> @@
>
> -memset(e,0x00,\(6\|ETH_ALEN\));
> +eth_zero_addr(e);
>
> Build tested it.
You need to do much more to prove that this is a safe change than just
test build it, sorry.
prev parent reply other threads:[~2015-09-12 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 5:37 [PATCH] Staging: wilc1000: wilc_wfi_cfgoperations.c: replace memset(x,0,ETH_ALEN) Shraddha Barke
2015-09-12 15:48 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912154841.GB29944@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).