From: Greg KH <gregkh@linuxfoundation.org>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: rachel.kim@atmel.com, devel@driverdev.osuosl.org,
chris.park@atmel.com, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com, tony.cho@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register
Date: Sun, 20 Sep 2015 19:01:43 -0700 [thread overview]
Message-ID: <20150921020143.GC22262@kroah.com> (raw)
In-Reply-To: <1442731885-4344-8-git-send-email-chaehyun.lim@gmail.com>
On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote:
> This patch removes function declaration of WILC_WFI_frame_register in
> linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file.
>
> The compilation warning occurs because it is assigned to incorrect
> pointer type of second parameter of WILC_WFI_frame_register.
> It is assigned with struct wireless_dev pointer type.
How was this code ever even working properly if the wrong pointer was
being passed into it?
Tony, what is going on here, is this code just never called? If so, can
we just delete the whole function?
thanks,
greg k-h
next prev parent reply other threads:[~2015-09-21 4:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 6:51 [PATCH 01/18] staging: wilc1000: rename WILC_WFI_WiphyFree Chaehyun Lim
2015-09-20 6:51 ` [PATCH 02/18] staging: wilc1000: rename WILC_WFI_WiphyRegister Chaehyun Lim
2015-09-20 6:51 ` [PATCH 03/18] staging: wilc1000: fix NULL comparison style Chaehyun Lim
2015-09-20 6:51 ` [PATCH 04/18] staging: wilc1000: remove blank line after an open brace '{' Chaehyun Lim
2015-09-20 6:51 ` [PATCH 05/18] staging: wilc1000: remove blank line before a close " Chaehyun Lim
2015-09-20 6:51 ` [PATCH 06/18] staging: wilc1000: replace PRINT_D with netdev_info Chaehyun Lim
2015-09-21 2:00 ` Greg KH
2015-09-20 6:51 ` [PATCH 07/18] staging: wilc1000: replaces PRINT_D with netdev_err Chaehyun Lim
2015-09-21 2:00 ` Greg KH
2015-09-20 6:51 ` [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register Chaehyun Lim
2015-09-21 2:01 ` Greg KH [this message]
2015-09-21 5:54 ` Tony Cho
2015-09-21 6:07 ` Greg KH
2015-09-21 6:20 ` Tony Cho
2015-09-21 6:50 ` Greg KH
2015-09-21 2:06 ` Greg KH
2015-09-20 6:51 ` [PATCH 09/18] staging: wilc1000: rename WILC_WFI_frame_register Chaehyun Lim
2015-09-20 6:51 ` [PATCH 10/18] staging: wilc1000: rename WILC_WFI_set_power_mgmt Chaehyun Lim
2015-09-21 2:03 ` Greg KH
2015-09-20 6:51 ` [PATCH 11/18] staging: wilc1000: rename WILC_WFI_set_cqm_rssi_config Chaehyun Lim
2015-09-21 6:52 ` Greg KH
2015-09-20 6:51 ` [PATCH 12/18] staging: wilc1000: remove useless comment Chaehyun Lim
2015-09-20 6:51 ` [PATCH 13/18] staging: wilc1000: wilc_msgqueue.c: replace s32RetStatus with result Chaehyun Lim
2015-09-20 6:51 ` [PATCH 14/18] staging: wilc1000: remove useless #if 1 Chaehyun Lim
2015-09-20 6:51 ` [PATCH 15/18] staging: wilc1000: remove braces for single statement blocks Chaehyun Lim
2015-09-20 6:51 ` [PATCH 16/18] staging: wilc1000: replace s32 with int Chaehyun Lim
2015-09-20 6:51 ` [PATCH 17/18] staging: wilc1000: rename WILC_WFI_DeInitHostInt Chaehyun Lim
2015-09-20 6:51 ` [PATCH 18/18] staging: wilc1000: rename WILC_WFI_InitHostInt Chaehyun Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921020143.GC22262@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).