From: Greg KH <gregkh@linuxfoundation.org>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: rachel.kim@atmel.com, devel@driverdev.osuosl.org,
chris.park@atmel.com, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com, tony.cho@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result
Date: Sun, 20 Sep 2015 23:06:52 -0700 [thread overview]
Message-ID: <20150921060652.GA24030@kroah.com> (raw)
In-Reply-To: <1442795132-19660-1-git-send-email-chaehyun.lim@gmail.com>
On Mon, Sep 21, 2015 at 09:25:31AM +0900, Chaehyun Lim wrote:
> Most of functions use s32Error variable to check error and return its value.
> This patch replaces s32Error with result to avoid CamelCase.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
This doesn't apply at all anymore.
I suggest doing as Julian said, fix this up correctly, no need to rename
a variable and then delete it in a later patch. Start doing good
content cleanups, not just name replacements.
thanks,
greg k-h
prev parent reply other threads:[~2015-09-21 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 0:25 [PATCH 1/2] staging: wilc1000: replace s32Error with result Chaehyun Lim
2015-09-21 0:25 ` [PATCH 2/2] staging: wilc1000: rename SendConfigPkt Chaehyun Lim
2015-09-21 0:40 ` [PATCH 1/2] staging: wilc1000: replace s32Error with result Julian Calaby
2015-09-21 0:52 ` Chaehyun Lim
2015-09-21 1:13 ` Chaehyun Lim
2015-09-21 6:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921060652.GA24030@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).