From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:45470 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbbIUGuj (ORCPT ); Mon, 21 Sep 2015 02:50:39 -0400 Date: Sun, 20 Sep 2015 23:50:37 -0700 From: Greg KH To: Tony Cho Cc: Chaehyun Lim , rachel.kim@atmel.com, devel@driverdev.osuosl.org, chris.park@atmel.com, linux-wireless@vger.kernel.org, johnny.kim@atmel.com, leo.kim@atmel.com Subject: Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register Message-ID: <20150921065037.GA26205@kroah.com> (sfid-20150921_085044_833548_63A64151) References: <1442731885-4344-1-git-send-email-chaehyun.lim@gmail.com> <1442731885-4344-8-git-send-email-chaehyun.lim@gmail.com> <20150921020143.GC22262@kroah.com> <55FF9B94.9020300@atmel.com> <20150921060758.GA24173@kroah.com> <55FFA19C.6020701@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <55FFA19C.6020701@atmel.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Sep 21, 2015 at 03:20:12PM +0900, Tony Cho wrote: > > > On 2015년 09월 21일 15:07, Greg KH wrote: > >On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote: > >> > >>On 2015년 09월 21일 11:01, Greg KH wrote: > >>>On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > >>>>This patch removes function declaration of WILC_WFI_frame_register in > >>>>linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. > >>>> > >>>>The compilation warning occurs because it is assigned to incorrect > >>>>pointer type of second parameter of WILC_WFI_frame_register. > >>>>It is assigned with struct wireless_dev pointer type. > >>>How was this code ever even working properly if the wrong pointer was > >>>being passed into it? > >>> > >>>Tony, what is going on here, is this code just never called? If so, can > >>>we just delete the whole function? > >>> > >>>thanks, > >>> > >>>greg k-h > >>This file with linux_wlan.c file is being fully changed, but at this time, the second parameter which passed as > >>net_device pointer instead of wireless_dev incorrectly is never being used inside the WILC_WFI_frame_register(). > >>That's why no problem is found yet. > >Then we should just delte the parameter entirely, no need to pass > >something into a function that is never used. > > This function is defined in the struct cfg80211_ops as the followings: > > void (*mgmt_frame_register)(struct wiphy *wiphy, > > > struct wireless_dev *wdev, > > > u16 frame_type, bool reg); > > So, the second parameter cannot be removed to connect the cfg80211 structure correctly. The second parameter > is not used just in wilc driver. It seems the second parameter is not famous in cfg80211 driver when looking for > other cfg80211 driver, just to get the private data, but the wilc driver gets it from struct wiphy. Ah, ok, that makes a bit more sense, thanks for explaining it, I'll go try to queue up the patch now... thanks, greg k-h