From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 2/3] ssb: make ssb_sdio_switch_core static
Date: Mon, 21 Sep 2015 18:10:59 +0200 [thread overview]
Message-ID: <20150921181059.680dc5b5@wiggum> (raw)
In-Reply-To: <1442821640-14582-2-git-send-email-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
On Mon, 21 Sep 2015 09:47:19 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> It's used locally only.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/ssb/sdio.c | 2 +-
> drivers/ssb/ssb_private.h | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/ssb/sdio.c b/drivers/ssb/sdio.c
> index b2d36f7..2278e43 100644
> --- a/drivers/ssb/sdio.c
> +++ b/drivers/ssb/sdio.c
> @@ -200,7 +200,7 @@ out:
> }
>
> /* host must be already claimed */
> -int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev)
> +static int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev)
> {
> u8 coreidx = dev->core_index;
> u32 sbaddr;
> diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
> index eb507a5..1d2256e 100644
> --- a/drivers/ssb/ssb_private.h
> +++ b/drivers/ssb/ssb_private.h
> @@ -132,7 +132,6 @@ extern int ssb_sdio_get_invariants(struct ssb_bus *bus,
> struct ssb_init_invariants *iv);
>
> extern u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset);
> -extern int ssb_sdio_switch_core(struct ssb_bus *bus, struct ssb_device *dev);
> extern int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx);
> extern int ssb_sdio_hardware_setup(struct ssb_bus *bus);
> extern void ssb_sdio_exit(struct ssb_bus *bus);
> @@ -144,11 +143,6 @@ static inline u32 ssb_sdio_scan_read32(struct ssb_bus *bus, u16 offset)
> {
> return 0;
> }
> -static inline int ssb_sdio_switch_core(struct ssb_bus *bus,
> - struct ssb_device *dev)
> -{
> - return 0;
> -}
> static inline int ssb_sdio_scan_switch_coreidx(struct ssb_bus *bus, u8 coreidx)
> {
> return 0;
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-21 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 7:47 [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Rafał Miłecki
2015-09-21 7:47 ` [PATCH 2/3] ssb: make ssb_sdio_switch_core static Rafał Miłecki
2015-09-21 16:10 ` Michael Büsch [this message]
2015-09-21 7:47 ` [PATCH 3/3] ssb: drop declaration of non existing ssb_sdio_hardware_setup Rafał Miłecki
2015-09-21 16:11 ` Michael Büsch
2015-09-21 16:10 ` [PATCH 1/3] ssb: unexport ssb_bus_pcibus_register Michael Büsch
2015-09-29 8:02 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921181059.680dc5b5@wiggum \
--to=m@bues.ch \
--cc=hauke@hauke-m.de \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).