Re: [PATCH 06/10] staging: wilc1000: rename hWFIDrv of host_int_set_mac_chnl_num

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Oct 02, 2015 at 09:44:52PM +0900, Chaehyun Lim wrote:
> This patch replaces hWFIDrv with wfi_drv that is first argument of
> host_int_set_mac_chnl_num to avoid camelcase.
> 
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 6 +++---
>  drivers/staging/wilc1000/host_interface.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 133bb2d..d23d2dd 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -5315,10 +5315,10 @@ s32 host_int_get_rx_power_level(tstrWILC_WFIDrv *hWFIDrv, u8 *pu8RxPowerLevel,
>   *  @date		8 March 2012
>   *  @version		1.0
>   */
> -int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *hWFIDrv, u8 channel)
> +int host_int_set_mac_chnl_num(tstrWILC_WFIDrv *wfi_drv, u8 channel)
>  {
>  	int result = 0;
> -	tstrWILC_WFIDrv *pstrWFIDrv = (tstrWILC_WFIDrv *)hWFIDrv;
> +	tstrWILC_WFIDrv *pstrWFIDrv = (tstrWILC_WFIDrv *)wfi_drv;

Not the issue here, but in the future, why is this cast needed?  Heck,
why is this local variable even needed, why not just use wifi_drv
everywhere in this function?

thanks,

greg k-h