From: Greg KH <gregkh@linuxfoundation.org>
To: glen lee <glen.lee@atmel.com>
Cc: devel@driverdev.osuosl.org, austin.shin@atmel.com,
linux-wireless@vger.kernel.org, Nicolas.FERRE@atmel.com,
adel.noureldin@atmel.com, tony.cho@atmel.com, leo.kim@atmel.com,
adham.abozaeid@atmel.com
Subject: Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc
Date: Mon, 26 Oct 2015 17:23:40 +0900 [thread overview]
Message-ID: <20151026082340.GA4643@kroah.com> (raw)
In-Reply-To: <562D8B2B.2000308@atmel.com>
On Mon, Oct 26, 2015 at 11:08:43AM +0900, glen lee wrote:
>
>
> On 2015년 10월 25일 10:29, Greg KH wrote:
> >On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote:
> >>Use netdev private member wilc instead of g_linux_wlan and Change argument wilc
> >>with dev in the function request_threaded_irq to pass back to handler
> >>the function isr_uh_routine.
> >>
> >>Signed-off-by: Glen Lee <glen.lee@atmel.com>
> >>---
> >> drivers/staging/wilc1000/linux_wlan.c | 9 +++++++--
> >> 1 file changed, 7 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> >>index b036b96..7b0614d 100644
> >>--- a/drivers/staging/wilc1000/linux_wlan.c
> >>+++ b/drivers/staging/wilc1000/linux_wlan.c
> >>@@ -229,10 +229,15 @@ static int dev_state_ev_handler(struct notifier_block *this, unsigned long event
> >> #if (defined WILC_SPI) || (defined WILC_SDIO_IRQ_GPIO)
> >> static irqreturn_t isr_uh_routine(int irq, void *user_data)
> >> {
> >>+ perInterface_wlan_t *nic;
> >>+ struct wilc *wl;
> >>+
> >>+ nic = netdev_priv(usedata);
> >This patch breaks the build, which means you didn't even test build the
> >series :(
>
> Hi greg,
>
> I built every patches I'v posted and also there is no build error for this patch.
I don't believe you, just look at the lines, it's obviously incorrect.
> Would you please reconsider this patch again?
Why would I ever accept a patch that is obviously wrong? I would be a
horrible subsystem maintainer, and you would not want me to merge an
obviously broken patch from someone else into this driver, breaking it,
right?
I have no idea why you would expect me to ever accept this patch as-is.
greg k-h
next prev parent reply other threads:[~2015-10-26 8:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 5:28 [PATCH 01/28] staging: wilc1000: isr_bh_routine: remove unused variable nic Glen Lee
2015-10-23 5:28 ` [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc Glen Lee
2015-10-25 1:29 ` Greg KH
2015-10-26 2:08 ` glen lee
2015-10-26 8:23 ` Greg KH [this message]
2015-10-26 9:15 ` glen lee
2015-10-23 5:28 ` [PATCH 03/28] staging: wilc1000: isr_bh_routine: use wilc instead of g_linux_wlan Glen Lee
2015-10-23 5:28 ` [PATCH 04/28] staging: wilc1000: deinit_irq: " Glen Lee
2015-10-23 5:28 ` [PATCH 05/28] staging: wilc1000: wilc_handle_isr: add argument wilc to wilc_handle_isr Glen Lee
2015-10-23 6:57 ` Dan Carpenter
2015-10-23 7:36 ` Tony Cho
2015-10-23 7:52 ` Dan Carpenter
2015-10-23 8:13 ` Tony Cho
2015-10-23 5:28 ` [PATCH 06/28] staging: wilc1000: wilc_wlan_handle_isr_ext: add argument struct wilc Glen Lee
2015-10-23 5:28 ` [PATCH 07/28] staging: wilc1000: wilc_wlan_handle_rxq: add new argument and use wilc Glen Lee
2015-10-23 5:28 ` [PATCH 08/28] staging: wilc1000: linux_wlan_mac_indicate: add " Glen Lee
2015-10-23 5:28 ` [PATCH 09/28] staging: wilc1000: linux_wlan_set_bssid: use wilc instead of g_linux_wlan Glen Lee
2015-10-23 5:28 ` [PATCH 10/28] staging: wilc1000: wlan_initialize_threads: change argument with net_device Glen Lee
2015-10-23 5:28 ` [PATCH 11/28] staging: wilc1000: linux_wlan_txq_task: use wilc instead of g_linux_wlan Glen Lee
2015-10-23 5:28 ` [PATCH 12/28] staging: wilc1000: wilc_wlan_handle_txq: add argument and use wilc Glen Lee
2015-10-23 5:28 ` [PATCH 13/28] staging: wilc1000: wilc_wlan_txq_filter_dup_tcp_ack: " Glen Lee
2015-10-23 5:28 ` [PATCH 14/28] staging: wilc1000: host_int_init: add argument net_device Glen Lee
2015-10-23 5:28 ` [PATCH 15/28] staging: wilc1000: wlan_deinit_locks: rename argument name and use it Glen Lee
2015-10-23 5:28 ` [PATCH 16/28] staging: wilc1000: WILC_WFI_mgmt_rx: add argument wilc " Glen Lee
2015-10-23 5:28 ` [PATCH 17/28] staging: wilc1000: wlan_deinitialize_threads: change argument and use wilc Glen Lee
2015-10-23 5:28 ` [PATCH 18/28] staging: wilc1000: mac_ioctl: use private data instead of g_linux_wlan Glen Lee
2015-10-23 5:28 ` [PATCH 19/28] staging: wilc1000: wilc_wlan_cleanup: add parameter net_device *dev Glen Lee
2015-10-23 5:28 ` [PATCH 20/28] staging: wilc1000: wilc_wlan_rxq_remove: add argument wilc and use it Glen Lee
2015-10-23 5:28 ` [PATCH 21/28] staging: wilc1000: frmw_to_linux: add argument struct wilc Glen Lee
2015-10-23 5:28 ` [PATCH 22/28] staging: wilc1000: GetIfHandler: add argument struct wilc and use it Glen Lee
2015-10-23 5:28 ` [PATCH 23/28] staging: wilc1000: Set_machw_change_vir_if: add argument dev Glen Lee
2015-10-23 5:28 ` [PATCH 24/28] staging: wilc1000: wilc_wlan_rxq_add: add argument wilc and use it Glen Lee
2015-10-23 5:28 ` [PATCH 25/28] staging: wilc1000: wilc_wlan_txq_get_next: add argument wilc Glen Lee
2015-10-23 5:28 ` [PATCH 26/28] staging: wilc1000: mac_xmit: use netdev private wilc instead of g_linux_wlan Glen Lee
2015-10-23 5:28 ` [PATCH 27/28] staging: wilc1000: wilc_wlan_txq_add_net_pkt: add argument struct net_device Glen Lee
2015-10-23 5:28 ` [PATCH 28/28] staging: wilc1000: tcp_process: add argument dev and get private from it Glen Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026082340.GA4643@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).