* [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()
@ 2015-10-27 17:21 Punit Vara
2015-10-27 19:40 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Punit Vara @ 2015-10-27 17:21 UTC (permalink / raw)
To: gregkh; +Cc: linux-wireless, linux-kernel, devel, johnny.kim, Punit Vara
This patch is to the host_interface.c that fixes up following
warning by checkpatch:
-prefer eth_broadcast_addr() over memset()
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 5f81eab..53e21cd 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -4642,7 +4642,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
msg.drv = hif_drv;
if (!pu8MacAddr)
- memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
+ eth_broadcast_addr(pstrDelStationMsg->mac_addr);
else
memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
--
2.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()
2015-10-27 17:21 [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset() Punit Vara
@ 2015-10-27 19:40 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-10-27 19:40 UTC (permalink / raw)
To: Punit Vara; +Cc: devel, linux-wireless, linux-kernel, johnny.kim
On Tue, Oct 27, 2015 at 10:51:39PM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch:
>
> -prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What changed from v1?
Always put that information here below the --- line so that we know.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-27 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-27 17:21 [PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset() Punit Vara
2015-10-27 19:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).