From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
Larry Finger <larry.finger@lwfinger.net>
Subject: Re: [PATCH 1/2] ssb: move functions specific to SoC hosted bus to separated file
Date: Tue, 27 Oct 2015 20:09:00 +0100 [thread overview]
Message-ID: <20151027200900.490e4b03@wiggum> (raw)
In-Reply-To: <1445797963-5968-1-git-send-email-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Sun, 25 Oct 2015 19:32:42 +0100
Rafał Miłecki <zajec5@gmail.com> wrote:
> This cleans main.c a bit and will allow us to compile SoC related code
> conditionally in the future.
Looks good.
Acked-by: Michael Buesch <m@bues.ch>
> +#ifdef CONFIG_SSB_BLOCKIO
I wonder whether we should remove that option entirely. It does not save
that much space and most people will probably have it enabled anyway.
It's required for non-DMA PIO transfers.
So if you want, you could remove that in a separate patch.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-27 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 18:32 [PATCH 1/2] ssb: move functions specific to SoC hosted bus to separated file Rafał Miłecki
2015-10-25 18:32 ` [PATCH 2/2] ssb: add Kconfig entry for compiling SoC related code Rafał Miłecki
2015-10-27 19:11 ` Michael Büsch
2015-10-27 19:09 ` Michael Büsch [this message]
2015-10-28 19:06 ` [PATCH 1/2] ssb: move functions specific to SoC hosted bus to separated file Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027200900.490e4b03@wiggum \
--to=m@bues.ch \
--cc=hauke@hauke-m.de \
--cc=kvalo@codeaurora.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).