linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Glen Lee <glen.lee@atmel.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	austin.shin@atmel.com, linux-wireless@vger.kernel.org,
	Nicolas.FERRE@atmel.com, adel.noureldin@atmel.com,
	tony.cho@atmel.com, leo.kim@atmel.com, adham.abozaeid@atmel.com
Subject: Re: [PATCH 38/80] staging: wilc1000: rename au8Bssid of struct ba_session_info
Date: Wed, 28 Oct 2015 19:56:06 +0300	[thread overview]
Message-ID: <20151028165606.GB18797@mwanda> (raw)
In-Reply-To: <1446015640-29398-38-git-send-email-glen.lee@atmel.com>

On Wed, Oct 28, 2015 at 03:59:58PM +0900, Glen Lee wrote:
> From: Leo Kim <leo.kim@atmel.com>
> 
> This patch renames au8Bssid of struct ba_session_info to bssid
> to avoid CamelCase naming convention.
> And, some debug logs modified because 80 ending line over warnings.
> 
> Signed-off-by: Leo Kim <leo.kim@atmel.com>
> Signed-off-by: Glen Lee <glen.lee@atmel.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 32 ++++++++++++++++++-------------
>  drivers/staging/wilc1000/host_interface.h |  2 +-
>  2 files changed, 20 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 9ad98fd..48a232f 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2715,10 +2715,14 @@ static s32 Handle_AddBASession(struct host_if_drv *hif_drv,
>  	int AddbaTimeout = 100;
>  	char *ptr = NULL;
>  
> -	PRINT_D(HOSTINF_DBG, "Opening Block Ack session with\nBSSID = %.2x:%.2x:%.2x\nTID=%d\nBufferSize == %d\nSessionTimeOut = %d\n",
> -		strHostIfBASessionInfo->au8Bssid[0],
> -		strHostIfBASessionInfo->au8Bssid[1],
> -		strHostIfBASessionInfo->au8Bssid[2],
> +	PRINT_D(HOSTINF_DBG, "Opening Block Ack session with \
> +		\nBSSID = %.2x:%.2x:%.2x \
> +		\nBufferSize == %d \
> +		\nSessionTimeOut = %d \
> +		\nTID=%d\n",
> +		strHostIfBASessionInfo->bssid[0],
> +		strHostIfBASessionInfo->bssid[1],
> +		strHostIfBASessionInfo->bssid[2],
>  		strHostIfBASessionInfo->u16BufferSize,
>  		strHostIfBASessionInfo->u16SessionTimeout,
>  		strHostIfBASessionInfo->u8Ted);

This should be a bunch of printks so that we have the correct debug
level at the start of each line.

regards,
dan carpenter


  reply	other threads:[~2015-10-28 16:56 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  6:59 [PATCH 01/80] staging: wilc1000: remove unnecessary parentheses around Glen Lee
2015-10-28  6:59 ` [PATCH 02/80] staging: wilc1000: fixes braces {} are not necessary for single statement blocks Glen Lee
2015-10-28  6:59 ` [PATCH 03/80] staging: wilc1000: fixes blank lines aren't necessary brace Glen Lee
2015-10-28  6:59 ` [PATCH 04/80] staging: wilc1000: fixes missing a blank line after declarations Glen Lee
2015-10-28  6:59 ` [PATCH 05/80] staging: wilc1000: fixes please don't use multiple blank lines Glen Lee
2015-10-28  6:59 ` [PATCH 06/80] staging: wilc1000: host_interface: removes unused functions Glen Lee
2015-10-28  7:21   ` Sudip Mukherjee
2015-10-28  7:30     ` glen lee
2015-10-28  6:59 ` [PATCH 07/80] staging: wilc1000: rename au8StartTime of struct join_bss_param Glen Lee
2015-10-28  6:59 ` [PATCH 08/80] staging: wilc1000: rename variable strWID Glen Lee
2015-10-28  6:59 ` [PATCH 09/80] staging: wilc1000: rename u32Address of struct drv_handler Glen Lee
2015-10-28  6:59 ` [PATCH 10/80] staging: wilc1000: rename u32Mode of struct op_mode Glen Lee
2015-10-28  6:59 ` [PATCH 11/80] staging: wilc1000: rename u8MacAddress of struct set_mac_addr Glen Lee
2015-10-28  6:59 ` [PATCH 12/80] staging: wilc1000: rename u8MacAddress of struct get_mac_addr Glen Lee
2015-10-28  6:59 ` [PATCH 13/80] staging: wilc1000: rename strWILC_UsrScanReq of struct host_if_drv Glen Lee
2015-10-28  6:59 ` [PATCH 14/80] staging: wilc1000: rename strWILC_UsrConnReq " Glen Lee
2015-10-28  6:59 ` [PATCH 15/80] staging: wilc1000: rename strHostIfRemainOnChan " Glen Lee
2015-10-28  6:59 ` [PATCH 16/80] staging: wilc1000: rename u8RemainOnChan_pendingreq " Glen Lee
2015-10-28  6:59 ` [PATCH 17/80] staging: wilc1000: rename enuHostIFstate " Glen Lee
2015-10-28 14:07   ` Dan Carpenter
2015-10-28  6:59 ` [PATCH 18/80] staging: wilc1000: rename au8AssociatedBSSID " Glen Lee
2015-10-28 23:46   ` Greg KH
2015-10-28  6:59 ` [PATCH 19/80] staging: wilc1000: rename strCfgValues " Glen Lee
2015-10-28  6:59 ` [PATCH 20/80] staging: wilc1000: rename gtOsCfgValuesSem " Glen Lee
2015-10-28  6:59 ` [PATCH 21/80] staging: wilc1000: rename hSemTestKeyBlock " Glen Lee
2015-10-28  6:59 ` [PATCH 22/80] staging: wilc1000: rename hSemTestDisconnectBlock " Glen Lee
2015-10-28  6:59 ` [PATCH 23/80] staging: wilc1000: rename hSemGetRSSI " Glen Lee
2015-10-28  6:59 ` [PATCH 24/80] staging: wilc1000: rename hSemGetLINKSPEED " Glen Lee
2015-10-28  6:59 ` [PATCH 25/80] staging: wilc1000: rename hSemGetCHNL " Glen Lee
2015-10-28  6:59 ` [PATCH 26/80] staging: wilc1000: rename hSemInactiveTime " Glen Lee
2015-10-28  6:59 ` [PATCH 27/80] staging: wilc1000: rename hScanTimer " Glen Lee
2015-10-28  6:59 ` [PATCH 28/80] staging: wilc1000: rename hConnectTimer " Glen Lee
2015-10-28  6:59 ` [PATCH 29/80] staging: wilc1000: rename hRemainOnChannel " Glen Lee
2015-10-28  6:59 ` [PATCH 30/80] staging: wilc1000: host_interface.h : remove over-commenting Glen Lee
2015-10-28  6:59 ` [PATCH 31/80] staging: wilc1000: rename bReg of struct reg_frame Glen Lee
2015-10-28  6:59 ` [PATCH 32/80] staging: wilc1000: rename u16FrameType " Glen Lee
2015-10-28  6:59 ` [PATCH 33/80] staging: wilc1000: rename u8Regid " Glen Lee
2015-10-28  6:59 ` [PATCH 34/80] staging: wilc1000: rename u16Channel of struct remain_ch Glen Lee
2015-10-28  6:59 ` [PATCH 35/80] staging: wilc1000: rename pRemainOnChanExpired " Glen Lee
2015-10-28  6:59 ` [PATCH 36/80] staging: wilc1000: rename pRemainOnChanReady " Glen Lee
2015-10-28  6:59 ` [PATCH 37/80] staging: wilc1000: rename pVoid " Glen Lee
2015-10-28  6:59 ` [PATCH 38/80] staging: wilc1000: rename au8Bssid of struct ba_session_info Glen Lee
2015-10-28 16:56   ` Dan Carpenter [this message]
2015-10-28 17:06     ` Joe Perches
2015-10-29  2:02     ` glen lee
2015-10-28  6:59 ` [PATCH 39/80] staging: wilc1000: rename u8Ted " Glen Lee
2015-10-28  7:00 ` [PATCH 40/80] staging: wilc1000: rename u16BufferSize " Glen Lee
2015-10-28  7:00 ` [PATCH 41/80] staging: wilc1000: rename u16SessionTimeout " Glen Lee
2015-10-28  7:00 ` [PATCH 42/80] staging: wilc1000: remove warnings line over 80 characters Glen Lee
2015-10-28  7:00 ` [PATCH 43/80] staging: wilc1000: rename pfUserScanResult of struct user_scan_req Glen Lee
2015-10-28  7:00 ` [PATCH 44/80] staging: wilc1000: rename u32UserScanPvoid " Glen Lee
2015-10-28  7:00 ` [PATCH 45/80] staging: wilc1000: rename astrFoundNetworkInfo " Glen Lee
2015-10-28  7:00 ` [PATCH 46/80] staging: wilc1000: rename ssidLen of struct user_conn_req Glen Lee
2015-10-28  7:00 ` [PATCH 47/80] staging: wilc1000: rename pu8ConnReqIEs " Glen Lee
2015-10-28  7:00 ` [PATCH 48/80] staging: wilc1000: rename ConnReqIEsLen " Glen Lee
2015-10-28  7:00 ` [PATCH 49/80] staging: wilc1000: rename pfUserConnectResult " Glen Lee
2015-10-28  7:00 ` [PATCH 50/80] staging: wilc1000: rename IsHTCapable " Glen Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028165606.GB18797@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=adel.noureldin@atmel.com \
    --cc=adham.abozaeid@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=glen.lee@atmel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).