From: Kalle Valo <kvalo@codeaurora.org>
To: yfw <fengwei.yin@linaro.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
me@bobcopeland.com, k.eugene.e@gmail.com,
bjorn.andersson@sonymobile.com, fengwei.yin@linaro.org
Subject: Re: wcn36xx: Remove warning message when dev is NULL for arm64 dma_alloc.
Date: Wed, 28 Oct 2015 18:59:40 +0000 (UTC) [thread overview]
Message-ID: <20151028185940.99B6C14158D@smtp.codeaurora.org> (raw)
In-Reply-To: <1445826982-4023-1-git-send-email-fengwei.yin@linaro.org>
> arm64 has requirement that all the dma operations have actual device.
> Otherwise, following warnning message shown and dma allocation fails:
>
> WARNING: CPU: 0 PID: 954 at arch/arm64/mm/dma-mapping.c:106 __dma_alloc+0x24c/0x258()
> Use an actual device structure for DMA allocation
> Modules linked in: wcn36xx wcn36xx_platform
> CPU: 0 PID: 954 Comm: ifconfig Not tainted 4.0.0+ #14
> Hardware name: Qualcomm Technologies, Inc. MSM 8916 MTP (DT)
> Call trace:
> [<ffffffc000089904>] dump_backtrace+0x0/0x124
> [<ffffffc000089a38>] show_stack+0x10/0x1c
> [<ffffffc000627114>] dump_stack+0x80/0xc4
> [<ffffffc0000b2e64>] warn_slowpath_common+0x98/0xd0
> [<ffffffc0000b2ee8>] warn_slowpath_fmt+0x4c/0x58
> [<ffffffc00009487c>] __dma_alloc+0x248/0x258
> [<ffffffbffc009270>] wcn36xx_dxe_allocate_mem_pools+0xc4/0x108 [wcn36xx]
> [<ffffffbffc0079c4>] wcn36xx_start+0x38/0x240 [wcn36xx]
> [<ffffffc0005f161c>] ieee80211_do_open+0x1b0/0x9a4
> [<ffffffc0005f1e68>] ieee80211_open+0x58/0x68
> [<ffffffc00051693c>] __dev_open+0xb0/0x120
> [<ffffffc000516c10>] __dev_change_flags+0x88/0x150
> [<ffffffc000516cf4>] dev_change_flags+0x1c/0x5c
> [<ffffffc000570950>] devinet_ioctl+0x644/0x6f0
>
> Signed-off-by: Yin, Fengwei <fengwei.yin@linaro.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
next prev parent reply other threads:[~2015-10-28 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 2:36 [PATCH] wcn36xx: Remove warning message when dev is NULL for arm64 dma_alloc Yin, Fengwei
2015-10-26 18:24 ` Bjorn Andersson
2015-10-27 0:06 ` yfw
2015-10-28 8:21 ` Eugene Krasnikov
2015-10-28 18:59 ` Kalle Valo [this message]
2015-10-29 20:01 ` Kalle Valo
2015-10-29 23:32 ` fengwei.yin
2015-10-29 23:34 ` fengwei.yin
2015-10-29 23:41 ` Nicolas Dechesne
2015-10-30 4:59 ` Kalle Valo
2015-10-30 5:49 ` yfw
2015-10-30 6:02 ` Kalle Valo
2015-10-30 6:05 ` fengwei.yin
2015-10-30 6:41 ` fengwei.yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028185940.99B6C14158D@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=fengwei.yin@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).