From: Dan Carpenter <dan.carpenter@oracle.com>
To: Glen Lee <glen.lee@atmel.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
austin.shin@atmel.com, linux-wireless@vger.kernel.org,
Nicolas.FERRE@atmel.com, adel.noureldin@atmel.com,
tony.cho@atmel.com, leo.kim@atmel.com, adham.abozaeid@atmel.com
Subject: Re: [PATCH 29/38] staging: wilc1000: remove goto from linux_wlan_start_firmware
Date: Mon, 2 Nov 2015 16:36:02 +0300 [thread overview]
Message-ID: <20151102133602.GE18797@mwanda> (raw)
In-Reply-To: <1446454281-22484-29-git-send-email-glen.lee@atmel.com>
On Mon, Nov 02, 2015 at 05:51:12PM +0900, Glen Lee wrote:
> PRINT_D(INIT_DBG, "Waiting for Firmware to get ready ...\n");
> ret = linux_wlan_lock_timeout(&wilc->sync_event, 5000);
> if (ret) {
> PRINT_D(INIT_DBG, "Firmware start timed out");
> - goto _fail_;
> + return ret;
> }
> PRINT_D(INIT_DBG, "Firmware successfully started\n");
>
> -_fail_:
> return ret;
In a later patch, could you change this from "return ret;" to
"return 0;"
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-02 13:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 8:50 [PATCH 01/38] staging: wilc1000: rename pu8IPAddr of fuction Handle_set_IPAddress Glen Lee
2015-11-02 8:50 ` [PATCH 02/38] staging: wilc1000: rename firmwareIPAddress " Glen Lee
2015-11-02 8:50 ` [PATCH 03/38] staging: wilc1000: remove unused parameter of fuction Handle_get_IPAddress Glen Lee
2015-11-02 8:50 ` [PATCH 04/38] staging: wilc1000: rename pstrHostIfSetMacAddress of fuction Handle_SetMacAddress Glen Lee
2015-11-02 8:50 ` [PATCH 05/38] staging: wilc1000: rename pstrHostIfGetMacAddress of fuction Handle_GetMacAddress Glen Lee
2015-11-02 8:50 ` [PATCH 06/38] staging: wilc1000: rename strHostIFCfgParamAttr of fuction Handle_CfgParam Glen Lee
2015-11-02 8:50 ` [PATCH 07/38] staging: wilc1000: remove return type of Handle_wait_msg_q_empty Glen Lee
2015-11-02 8:50 ` [PATCH 08/38] staging: wilc1000: rename gau8MulticastMacAddrList variable Glen Lee
2015-11-02 8:50 ` [PATCH 09/38] staging: wilc1000: replace explicit NULL comparisons with ! Glen Lee
2015-11-02 8:50 ` [PATCH 10/38] staging: wilc1000: linux_wlan: remove unused define CUSTOMER_PLATFORM Glen Lee
2015-11-02 8:50 ` [PATCH 11/38] staging: wilc1000: rename pstrWFIDrv of function dev_state_ev_handler Glen Lee
2015-11-02 8:50 ` [PATCH 12/38] staging: wilc1000: rename pstrWFIDrv of function linux_wlan_init_test_config Glen Lee
2015-11-02 8:50 ` [PATCH 13/38] staging: wilc1000: rename pstrWFIDrv of function wilc_set_multicast_list Glen Lee
2015-11-02 8:50 ` [PATCH 14/38] staging: wilc1000: rename pstrWFIDrv of function mac_close Glen Lee
2015-11-02 8:50 ` [PATCH 15/38] staging: wilc1000: rename pIP_Add_buff of function dev_state_ev_handler Glen Lee
2015-11-02 8:50 ` [PATCH 16/38] staging: wilc1000: fixes blank lines aren't necessary brace Glen Lee
2015-11-02 8:51 ` [PATCH 17/38] staging: wilc1000: linux_wlan.c: clean up comments Glen Lee
2015-11-02 8:51 ` [PATCH 18/38] staging: wilc1000: linux_wlan: remove unused defines Glen Lee
2015-11-02 8:51 ` [PATCH 19/38] staging: wilc1000: remove extern function in c file and move it to header file Glen Lee
2015-11-02 8:51 ` [PATCH 20/38] staging: wilc1000: remove warnings line over 80 characters Glen Lee
2015-11-02 8:51 ` [PATCH 21/38] staging: wilc1000: fixes add spaces required around that '&&' Glen Lee
2015-11-02 8:51 ` [PATCH 22/38] staging: wilc1000: remove do-nothing if condition case Glen Lee
2015-11-02 8:51 ` [PATCH 23/38] staging: wilc1000: rename function GetIfHandler Glen Lee
2015-11-02 8:51 ` [PATCH 24/38] staging: wilc1000: rename pMacHeader of function get_if_handler Glen Lee
2015-11-02 8:51 ` [PATCH 25/38] staging: wilc1000: rename Bssid " Glen Lee
2015-11-02 8:51 ` [PATCH 26/38] staging: wilc1000: rename Bssid1 " Glen Lee
2015-11-02 8:51 ` [PATCH 27/38] staging: wilc1000: rename pBSSID of function linux_wlan_set_bssid Glen Lee
2015-11-02 8:51 ` [PATCH 28/38] staging: wilc1000: fixes braces {} should be used on all arms of this statement Glen Lee
2015-11-02 8:51 ` [PATCH 29/38] staging: wilc1000: remove goto from linux_wlan_start_firmware Glen Lee
2015-11-02 13:36 ` Dan Carpenter [this message]
2015-11-02 8:51 ` [PATCH 30/38] staging: wilc1000: remove goto from linux_wlan_firmware_download Glen Lee
2015-11-02 8:51 ` [PATCH 31/38] staging: wilc1000: fixes missing a blank line after declarations Glen Lee
2015-11-02 8:51 ` [PATCH 32/38] staging: wilc1000: remove goto from wlan_initialize_threads Glen Lee
2015-11-02 8:51 ` [PATCH 33/38] staging: wilc1000: remove goto from mac_open Glen Lee
2015-11-02 8:51 ` [PATCH 34/38] staging: wilc1000: rename Set_machw_change_vir_if function Glen Lee
2015-11-02 8:51 ` [PATCH 35/38] staging: wilc1000: rename host_int_get_MacAddress function Glen Lee
2015-11-02 8:51 ` [PATCH 36/38] staging: wilc1000: rename s32Error of mac_ioctl function Glen Lee
2015-11-02 8:51 ` [PATCH 37/38] staging: wilc1000: rename QueueCount of mac_xmit function Glen Lee
2015-11-02 8:51 ` [PATCH 38/38] staging: wilc1000: rename pu8UdpBuffer " Glen Lee
2015-11-04 20:51 ` [PATCH 01/38] staging: wilc1000: rename pu8IPAddr of fuction Handle_set_IPAddress Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102133602.GE18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).