From: Bob Copeland <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211_hwsim: stop using pointers as cookies
Date: Sun, 8 Nov 2015 18:49:23 -0500 [thread overview]
Message-ID: <20151108234923.GA30106@localhost> (raw)
In-Reply-To: <1446807443-12133-1-git-send-email-johannes@sipsolutions.net>
On Fri, Nov 06, 2015 at 11:57:23AM +0100, Johannes Berg wrote:
> Instead of using pointers, use sequentially assigned cookies.
> This is easier to understand while debugging and also avoids
> problems when the pointer is reused for the next allocation.
I tested this out in wmediumd and it didn't go so well...
> + info->rate_driver_data[0] = (void *)cookie;
[...]
> + skb_cookie = (u64)(uintptr_t)txi->driver_data[0];
rate_driver_data vs driver_data?
--
Bob Copeland %% http://bobcopeland.com/
next prev parent reply other threads:[~2015-11-08 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 10:57 [PATCH] mac80211_hwsim: stop using pointers as cookies Johannes Berg
2015-11-08 23:49 ` Bob Copeland [this message]
2015-11-27 13:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151108234923.GA30106@localhost \
--to=me@bobcopeland.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).