linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211: mesh: print MAC address instead of pointer
@ 2015-11-06 10:30 Johannes Berg
  2015-11-08 23:53 ` Bob Copeland
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2015-11-06 10:30 UTC (permalink / raw)
  To: linux-wireless; +Cc: Bob Copeland, Johannes Berg

From: Johannes Berg <johannes.berg@intel.com>

There's no point in printing the mpath pointer since it can't
be used for anything - print the MAC address instead (like in
the forwarding case.)

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/mac80211/mesh_pathtbl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index b890e225a8f1..778fdfc7f14a 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -968,8 +968,8 @@ int mesh_path_send_to_gates(struct mesh_path *mpath)
 			copy = true;
 		} else {
 			mpath_dbg(sdata,
-				  "Not forwarding %p (flags %#x)\n",
-				  gate->mpath, gate->mpath->flags);
+				  "Not forwarding to %pM (flags %#x)\n",
+				  gate->mpath->dst, gate->mpath->flags);
 		}
 	}
 
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: mesh: print MAC address instead of pointer
  2015-11-06 10:30 [PATCH] mac80211: mesh: print MAC address instead of pointer Johannes Berg
@ 2015-11-08 23:53 ` Bob Copeland
  0 siblings, 0 replies; 2+ messages in thread
From: Bob Copeland @ 2015-11-08 23:53 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless, Johannes Berg

On Fri, Nov 06, 2015 at 11:30:46AM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> There's no point in printing the mpath pointer since it can't
> be used for anything - print the MAC address instead (like in
> the forwarding case.)
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

FWIW:

Acked-by: Bob Copeland <me@bobcopeland.com>

>  			mpath_dbg(sdata,
> -				  "Not forwarding %p (flags %#x)\n",
> -				  gate->mpath, gate->mpath->flags);
> +				  "Not forwarding to %pM (flags %#x)\n",
> +				  gate->mpath->dst, gate->mpath->flags);

-- 
Bob Copeland %% http://bobcopeland.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-08 23:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-06 10:30 [PATCH] mac80211: mesh: print MAC address instead of pointer Johannes Berg
2015-11-08 23:53 ` Bob Copeland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).