From: Dan Carpenter <dan.carpenter@oracle.com>
To: glen lee <glen.lee@atmel.com>
Cc: Punit Vara <punitvara@gmail.com>,
devel@driverdev.osuosl.org, chris.park@atmel.com,
austin.shin@atmel.com, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
linux-kernel@vger.kernel.org, tony.cho@atmel.com,
leo.kim@atmel.com
Subject: Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq
Date: Mon, 9 Nov 2015 11:18:42 +0300 [thread overview]
Message-ID: <20151109081842.GR18797@mwanda> (raw)
In-Reply-To: <56405328.4040004@atmel.com>
On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote:
> Hi Punit Vara,
>
> I cannot find build errors on my build machines.
>
> According the log which you have posted before says *wilc is undeclared in the function init_wilc_driver,
> which means WILC_SPI is selected because one of SPI or SDIO should be chosen at the moment.
> Hence, struct wilc *wilc should be compiled together.
> It looks like wilc1000 is compiled without SPI or SDIO.
>
> Of course, there are many cases that I don't know, so you could let me know the wilc1000 build configuration?
>
> static int __init init_wilc_driver(void)
> {
> #ifdef WILC_SPI
This should be #ifndef WILC_SDIO
> struct wilc *wilc;
> #endif
But the large question remains of why do we have this variable here any
way?
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-09 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 21:31 [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq Punit Vara
2015-11-08 21:59 ` Dan Carpenter
2015-11-09 2:03 ` glen lee
2015-11-09 8:02 ` glen lee
2015-11-09 8:18 ` Dan Carpenter [this message]
2015-11-09 8:51 ` punit vara
2015-11-09 8:55 ` glen lee
2015-11-09 9:05 ` punit vara
2015-11-09 10:01 ` glen lee
2015-11-09 10:13 ` punit vara
2015-11-09 10:23 ` Sudip Mukherjee
2015-11-09 14:39 ` punit vara
2015-11-13 14:18 ` Sudip Mukherjee
2015-12-02 3:09 ` punit vara
2015-12-02 7:00 ` Sudip Mukherjee
2015-12-02 7:31 ` punit vara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109081842.GR18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=punitvara@gmail.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).