From: Peter Zijlstra <peterz@infradead.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Jason Baron <jbaron@akamai.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC 0/4] mac80211: jump labels for hw flags
Date: Mon, 9 Nov 2015 23:42:59 +0100 [thread overview]
Message-ID: <20151109224259.GP17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1447106557-17684-1-git-send-email-johannes@sipsolutions.net>
On Mon, Nov 09, 2015 at 11:02:33PM +0100, Johannes Berg wrote:
> As far as the code is concerned, there are two really ugly things:
> 1) I still use struct static_key - couldn't quite figure it out
> with static_key_false. I think I can replace it easily though.
Yeah, didn't see anything that would avoid using struct
static_key_false. Was there anything specific that was difficult?
> 2) There are a lot of boilerplate ifdefs/macros.
I'm sure we can reduce that a lot with some CPP trickery, lots of that
looked like endless repetition of the same pattern.
next prev parent reply other threads:[~2015-11-09 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 22:02 [RFC 0/4] mac80211: jump labels for hw flags Johannes Berg
2015-11-09 22:02 ` [RFC 1/4] mac80211: add ieee80211_hw_clear() Johannes Berg
2015-11-09 22:02 ` [RFC 2/4] mac80211: introduce ieee80211_local_check() Johannes Berg
2015-11-09 22:02 ` [RFC 3/4] mac80211: use static keys for hw flags Johannes Berg
2015-11-09 22:02 ` [RFC 4/4] mac80211: test the static key code Johannes Berg
2015-11-09 22:42 ` Peter Zijlstra [this message]
2015-11-10 7:43 ` [RFC 0/4] mac80211: jump labels for hw flags Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109224259.GP17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jbaron@akamai.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).