From: Bogicevic Sasa <brutallesale@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: gregkh@linuxfoundation.org, johnny.kim@atmel.com,
austin.shin@atmel.com, chris.park@atmel.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages
Date: Wed, 18 Nov 2015 12:30:16 +0100 [thread overview]
Message-ID: <20151118113016.GA26728@gmail.com> (raw)
In-Reply-To: <20151118061927.GA6229@sudip-pc>
On 11/18, Sudip Mukherjee wrote:
>On Tue, Nov 17, 2015 at 09:01:28PM +0100, Bogicevic Sasa wrote:
>> This fixes all "Comparison to NULL could be written like..."
>> messages from checkpatch.pl
>>
>> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
>> ---
>> drivers/staging/wilc1000/coreconfigurator.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
>> index fd7240c..a31ac55 100644
>> --- a/drivers/staging/wilc1000/coreconfigurator.c
>> +++ b/drivers/staging/wilc1000/coreconfigurator.c
>> @@ -434,7 +434,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
>>
>> /* Get DTIM Period */
>> pu8TimElm = get_tim_elm(pu8msa, u16RxLen + FCS_LEN, u8index);
>> - if (pu8TimElm != NULL)
>> + if (!pu8TimElm)
>
>You are now checking for - if (pu8TimElm == NULL)
>It should actually be: if (pu8TimElm)
>
>regards
>sudip
Right, so stuped, Ill resend it
prev parent reply other threads:[~2015-11-18 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 20:01 [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages Bogicevic Sasa
2015-11-18 6:19 ` Sudip Mukherjee
2015-11-18 11:30 ` Bogicevic Sasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118113016.GA26728@gmail.com \
--to=brutallesale@gmail.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).