From: Greg KH <gregkh@linuxfoundation.org>
To: glen lee <glen.lee@atmel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, austin.shin@atmel.com,
linux-wireless@vger.kernel.org, Nicolas.FERRE@atmel.com,
adel.noureldin@atmel.com, tony.cho@atmel.com, leo.kim@atmel.com,
adham.abozaeid@atmel.com
Subject: Re: [PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx
Date: Thu, 19 Nov 2015 07:45:51 -0800 [thread overview]
Message-ID: <20151119154551.GB7601@kroah.com> (raw)
In-Reply-To: <564D71EE.20704@atmel.com>
On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote:
>
>
> On 2015년 11월 19일 15:23, Dan Carpenter wrote:
> >On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
> >>This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
> >>this name could be confused index of txq_entry_t. It is index of tcp pending
> >>ack.
> >>
> >>It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da
> >>
> >It is just a cleanup patch and not a bugfix patch so "fix" is the wrong
> >word here. But the correct format for fixes tags is:
> >
> >Fixes: 123456789012 ('Title of patch')
>
> I see, I learned another one. Thanks.
Git can do this automatically for you:
git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
I have an alias for this to make it easier to use frequently.
greg k-h
next prev parent reply other threads:[~2015-11-19 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 2:05 [PATCH 1/4] staging: wilc1000: remove define COMPLEMENT_BOOT Glen Lee
2015-11-19 2:05 ` [PATCH 2/4] staging: wilc1000: remove wilc memory allocation config Glen Lee
2015-11-19 2:06 ` [PATCH 3/4] staging: wilc1000: rename index to tcp_pending_ack_idx Glen Lee
2015-11-19 6:23 ` Dan Carpenter
2015-11-19 6:53 ` glen lee
2015-11-19 15:45 ` Greg KH [this message]
2015-11-20 1:30 ` glen lee
2015-11-19 2:06 ` [PATCH 4/4] staging: wilc1000: use kernel define byte order macros Glen Lee
2015-11-19 6:19 ` [PATCH 1/4] staging: wilc1000: remove define COMPLEMENT_BOOT Dan Carpenter
2015-11-19 6:33 ` glen lee
2015-12-18 22:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119154551.GB7601@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).