From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "Li, Yanbo" <yanbol@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode
Date: Fri, 20 Nov 2015 19:02:16 +0530 [thread overview]
Message-ID: <20151120133214.GA15797@shafi-laptop> (raw)
In-Reply-To: <87si45zmpj.fsf@kamboji.qca.qualcomm.com>
Hi Kalle\Yanbo,
On Mon, Nov 16, 2015 at 10:57:44PM +0200, Kalle Valo wrote:
> "Li, Yanbo" <yanbol@qca.qualcomm.com> writes:
>
> >> > + /* The padding bytes's location is different on various chips */
> >> > + enum ath10k_loc_4addr_pad loc_4addr_pad;
> >>
> >> I think that loc prefix is a bit misleading, it reminds me of
> >> locationing/positioning etc. What about ath10k_hw_4addr_pad?
> >>
> >
> >
> > There is already a FW feature defined as
> > "ATH10K_FW_FEATURE_NO_NWIFI_DECAP_4ADDR_PADDIND" and the relative
> > string is "no-4addr-pad", if we just remove the "loc" prefix, it may
> > be confuse with this FW feature.
> >
> > How about we change the loc to offset in this case or any better suggestion?
>
> I did some naming changes in the pending branch:
>
> https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=42cd3832cd7c78bfeabb639a4086c7838fda5b57
>
> Please review and let me know what you think.
Please merge this change, as this is a critical fix (I hope Yanbo is fine with
the change in naming convention). I went through the change, it looks good to
me and I had tested the earlier version and it fixed a Repeater mode bug.
regards,
shafi
>
> --
> Kalle Valo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-20 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 4:50 [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode Yanbo Li
2015-10-23 5:24 ` Kalle Valo
2015-10-23 6:10 ` Li, Yanbo
2015-11-16 20:57 ` Kalle Valo
2015-11-20 13:32 ` Mohammed Shafi Shajakhan [this message]
2015-11-20 17:59 ` Li, Yanbo
2015-11-23 15:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120133214.GA15797@shafi-laptop \
--to=mohammed@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yanbol@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).