From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:31894 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759590AbbKTNcq (ORCPT ); Fri, 20 Nov 2015 08:32:46 -0500 Date: Fri, 20 Nov 2015 19:02:16 +0530 From: Mohammed Shafi Shajakhan To: Kalle Valo CC: "Li, Yanbo" , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode Message-ID: <20151120133214.GA15797@shafi-laptop> (sfid-20151120_143249_579064_37450597) References: <1445575816-4500-1-git-send-email-yanbol@qca.qualcomm.com> <877fme40ny.fsf@kamboji.qca.qualcomm.com> <2cd04da006cb4f2a8eea859b6aad3e10@nasanexm02e.na.qualcomm.com> <87si45zmpj.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <87si45zmpj.fsf@kamboji.qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Kalle\Yanbo, On Mon, Nov 16, 2015 at 10:57:44PM +0200, Kalle Valo wrote: > "Li, Yanbo" writes: > > >> > + /* The padding bytes's location is different on various chips */ > >> > + enum ath10k_loc_4addr_pad loc_4addr_pad; > >> > >> I think that loc prefix is a bit misleading, it reminds me of > >> locationing/positioning etc. What about ath10k_hw_4addr_pad? > >> > > > > > > There is already a FW feature defined as > > "ATH10K_FW_FEATURE_NO_NWIFI_DECAP_4ADDR_PADDIND" and the relative > > string is "no-4addr-pad", if we just remove the "loc" prefix, it may > > be confuse with this FW feature. > > > > How about we change the loc to offset in this case or any better suggestion? > > I did some naming changes in the pending branch: > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=42cd3832cd7c78bfeabb639a4086c7838fda5b57 > > Please review and let me know what you think. Please merge this change, as this is a critical fix (I hope Yanbo is fine with the change in naming convention). I went through the change, it looks good to me and I had tested the earlier version and it fixed a Repeater mode bug. regards, shafi > > -- > Kalle Valo > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html