From: Olav Haugan <ohaugan@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, davem@davemloft.net,
kvalo@codeaurora.org, ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH 1/2] mac80211: add support to set_coalesce
Date: Sun, 22 Nov 2015 20:02:56 -0800 [thread overview]
Message-ID: <20151123040255.GA30395@codeaurora.org> (raw)
In-Reply-To: <1446199181.3261.21.camel@sipsolutions.net>
On 15-10-30 10:59:41, Johannes Berg wrote:
>
> > +++ b/net/mac80211/driver-ops.h
> > @@ -1355,4 +1355,16 @@ static inline void drv_wake_tx_queue(struct
> > ieee80211_local *local,
> > local->ops->wake_tx_queue(&local->hw, &txq->txq);
> > }
> >
> > +static inline int drv_set_coalesce(struct ieee80211_local *local,
> > + struct cfg80211_coalesce
> > *coalesce)
> > +{
> > + u32 ret = 0;
> >
> This doesn't seem right - now you're accepting any call even if it's
> not really done by the driver?
>
I assume you mean we need the following check:
if (!local->ops->set_coalesce)
return -EOPNOTSUPP
--
.Olav
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-23 4:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 18:50 [PATCH 1/2] mac80211: add support to set_coalesce Olav Haugan
2015-10-24 18:50 ` [PATCH 2/2] ath9k: implement set_coalesce callback Olav Haugan
2015-10-30 10:00 ` Johannes Berg
2015-11-23 4:12 ` Olav Haugan
2015-11-23 8:52 ` Johannes Berg
2015-10-30 9:59 ` [PATCH 1/2] mac80211: add support to set_coalesce Johannes Berg
2015-11-23 4:02 ` Olav Haugan [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-24 18:49 Olav Haugan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123040255.GA30395@codeaurora.org \
--to=ohaugan@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).