From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40831 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbbKZME5 (ORCPT ); Thu, 26 Nov 2015 07:04:57 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: brcm80211: Delete an unnecessary check before the function call"release_firmware" From: Kalle Valo In-Reply-To: <563C5DA2.3000005@users.sourceforge.net> To: SF Markus Elfring Cc: Arend van Spriel , Brett Rudley , "Franky (Zhenhui) Lin" , Hante Meuleman , brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Message-Id: <20151126120450.AA72313F2A0@smtp.codeaurora.org> (sfid-20151126_130535_711372_726F8C20) Date: Thu, 26 Nov 2015 12:04:50 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > From: Markus Elfring > Date: Fri, 6 Nov 2015 08:48:23 +0100 > > The release_firmware() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > Acked-by: Arend van Spriel Thanks, applied to wireless-drivers-next.git. Kalle Valo