linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Arend van Spriel <arend@broadcom.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 08/11] brcmfmac: Make 5G join preference configurable.
Date: Tue, 1 Dec 2015 13:08:27 +0200	[thread overview]
Message-ID: <20151201110827.GA4362@w1.fi> (raw)
In-Reply-To: <87d1uqijnz.fsf@kamboji.qca.qualcomm.com>

On Tue, Dec 01, 2015 at 11:48:32AM +0200, Kalle Valo wrote:
> Arend van Spriel <arend@broadcom.com> writes:
> > It solves a problem for us, but admittedly it is not something that is
> > very usable by user-space apps. So I guess what you are suggesting
> > here is to come up with a nl80211 api for this. On the mailing list
> > (or hostap list) the topic pops up from time to time so there are
> > people who would like to have such a knob to play with. Still would
> > like to keep the module parameter although its use may change when
> > nl80211 api is added.
> 
> I don't know what is the best approach, that's why I would like to hear
> opinions from others. Personally I don't like the idea of adding 802.11
> level configuration options to module parameters, but on the other hand
> I don't have any strong opinions about this.

I would like to see this as a new attribute to NL80211_CMD_CONNECT to
provide parameters for offloaded (driver and/or firmware) BSS selection
and roaming. If there is a driver that uses roaming offload with
NL80211_CMD_ASSOCIATE, the same attribute could be used there (but I'm
not sure how exact such offloading would work in practice since I'd
expect both authentication and (re)association to be offloaded).

> I guess we have two different designs, one where the roaming logic is in
> firmware and other where wpasupplicant is responsible for this. (And I
> assume that brcfmac belongs to the former group.) Ideally it would be
> nice that we would have a same configuration knob for both but I don't
> know if that's really feasible.

Both of these would work as long as wpa_supplicant has means for
providing such configuration to the driver in a generic manner. That
NL80211_CMD_CONNECT extension with a new optional attribute would be
such a generic design.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

  reply	other threads:[~2015-12-01 11:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 10:32 [PATCH 00/11] brcmfmac: beamforming support and cleanup Arend van Spriel
2015-11-25 10:32 ` [PATCH 01/11] brcmfmac: Cleanup ssid storage Arend van Spriel
2015-11-30 12:48   ` [01/11] " Kalle Valo
2015-11-30 12:49     ` Kalle Valo
2015-11-25 10:32 ` [PATCH 02/11] brcmfmac: Return actual error by fwil Arend van Spriel
2015-11-25 10:32 ` [PATCH 03/11] brcmfmac: Change error print on wlan0 existence Arend van Spriel
2015-11-25 10:32 ` [PATCH 04/11] brcmfmac: no retries on rxglom superframe errors Arend van Spriel
2015-11-25 10:32 ` [PATCH 05/11] brcmfmac: Remove redundant parameter action from scan Arend van Spriel
2015-11-25 10:32 ` [PATCH 06/11] brcmfmac: Cleanup roaming configuration Arend van Spriel
2015-11-25 10:32 ` [PATCH 07/11] brcmfmac: Add beamforming support Arend van Spriel
2015-11-25 10:32 ` [PATCH 08/11] brcmfmac: Make 5G join preference configurable Arend van Spriel
2015-11-30 10:58   ` Kalle Valo
2015-12-01  8:33     ` Arend van Spriel
2015-12-01  9:48       ` Kalle Valo
2015-12-01 11:08         ` Jouni Malinen [this message]
2015-12-02 13:32           ` Arend van Spriel
2015-12-02 15:12             ` Jouni Malinen
2015-12-02 16:38             ` Dan Williams
2015-12-02 18:00               ` Paul Stewart
2015-12-02 21:07                 ` Dan Williams
2015-12-03 21:28                 ` Arend van Spriel
2015-11-25 10:32 ` [PATCH 09/11] brcmfmac: assure net_ratelimit() is declared before use Arend van Spriel
2015-11-25 10:32 ` [PATCH 10/11] brcmfmac: Unify methods to define and map firmware files Arend van Spriel
2015-11-25 10:32 ` [PATCH 11/11] brcmfmac: Fix double free on exception at module load Arend van Spriel
2015-11-30 11:00   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201110827.GA4362@w1.fi \
    --to=j@w1.fi \
    --cc=arend@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=meuleman@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).