From: Tony Lindgren <tony@atomide.com>
To: Uri Mashiach <uri.mashiach@compulab.co.il>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Kalle Valo <kvalo@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
bcousson@baylibre.com, Igor Grinberg <grinberg@compulab.co.il>,
Eliad Peller <eliad@wizery.com>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support
Date: Wed, 23 Dec 2015 07:36:31 -0800 [thread overview]
Message-ID: <20151223153630.GK2793@atomide.com> (raw)
In-Reply-To: <567AB1CB.1050203@compulab.co.il>
* Uri Mashiach <uri.mashiach@compulab.co.il> [151223 06:38]:
> On 12/23/2015 12:25 PM, Grygorii Strashko wrote:
>
> >>+ that services interrupts for this device
> >>+- vwlan-supply : Point the node of the regulator that controls the wl1271 chip WLAN_EN pin
> >
> >Pls, use gpio if this is required just to toggle WLAN_EN pin.
> >
> >[ti,] power-gpio or en-gpio
> >
> >
>
> The controller's power might need toggling in some board implementation.
> Maybe GPIO and regulator should be implemented?
Yes a regulator for wlcore is best here because to properly control it
and the wait needed.
Regards,
Tony
next prev parent reply other threads:[~2015-12-23 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 8:35 [PATCH 0/3] wlcore/wl12xx: spi: add wifi support to cm-t335 Uri Mashiach
2015-12-23 8:35 ` [PATCH 1/3] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops) Uri Mashiach
2015-12-23 10:08 ` Grygorii Strashko
2015-12-23 14:11 ` Uri Mashiach
2015-12-23 8:35 ` [PATCH 2/3] wlcore/wl12xx: spi: add device tree support Uri Mashiach
2015-12-23 10:25 ` Grygorii Strashko
2015-12-23 14:38 ` Uri Mashiach
2015-12-23 15:36 ` Tony Lindgren [this message]
2015-12-24 7:41 ` Uri Mashiach
2015-12-30 16:30 ` Rob Herring
2015-12-23 8:35 ` [PATCH 3/3] wlcore/wl12xx: spi: add wifi support to cm-t335 Uri Mashiach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223153630.GK2793@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=galak@codeaurora.org \
--cc=grinberg@compulab.co.il \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=uri.mashiach@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).