From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: glen lee <glen.lee@atmel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Austin Shin <austin.shin@atmel.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Nicolas.FERRE@atmel.com, adel.noureldin@atmel.com,
Tony Cho <tony.cho@atmel.com>,
leo.kim@atmel.com, adham.abozaeid@atmel.com
Subject: Re: [PATCH] staging: wilc1000: remove wilc_sdio_init
Date: Thu, 24 Dec 2015 09:59:34 +0300 [thread overview]
Message-ID: <20151224065934.GA5284@mwanda> (raw)
In-Reply-To: <CAGRGNgUv66UgjxA=Yoxy-+9FRpcVOixxc2pPRkWYQxe0ye5J=w@mail.gmail.com>
I kind of feel like we have started to err on the side of breaking
things up into too many patches. Linus has said the same thing...
This patch is not hard to review, except that the title was bad.
Originally it was sent as:
[PATCH] staging: wilc1000: fix bug in sdio/spi
which is the correct title, but the Fixes tag was in the wrong format so
Greg rejected it. Now the Fixes tag is missing entirely which is
useless and it is disguised as a cleanup. Cleanup patches should not
change run time and fixes should be marked clearly.
regards,
dan carpenter
prev parent reply other threads:[~2015-12-24 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 2:33 [PATCH] staging: wilc1000: remove wilc_sdio_init Glen Lee
2015-12-24 2:39 ` Julian Calaby
2015-12-24 3:06 ` glen lee
2015-12-24 3:07 ` Julian Calaby
2015-12-24 3:16 ` glen lee
2015-12-24 6:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224065934.GA5284@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=adel.noureldin@atmel.com \
--cc=adham.abozaeid@atmel.com \
--cc=austin.shin@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=julian.calaby@gmail.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).