Re: [PATCH] mwifiex: correctly handling kzalloc

David Miller
2015-12-29T20:09:30Z

From: Insu Yun <wuninsu@gmail.com>
Date: Tue, 29 Dec 2015 14:55:25 -0500

> Since kzalloc can be failed in memory pressure,
> it needs to be handled as above kzalloc.
>
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
> drivers/net/wireless/mwifiex/sdio.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
> index 78a8474..d114934 100644
> --- a/drivers/net/wireless/mwifiex/sdio.c
> +++ b/drivers/net/wireless/mwifiex/sdio.c
> @@ -2053,8 +2053,14 @@ static int mwifiex_init_sdio(struct mwifiex_adapter *adapter)
> /* Allocate skb pointer buffers */
> card->mpa_rx.skb_arr = kzalloc((sizeof(void *)) *
> card->mp_agg_pkt_limit, GFP_KERNEL);
> + if (!card->mpa_rx.skb_arr)
> + return -ENOMEM;
> +
> card->mpa_rx.len_arr = kzalloc(sizeof(*card->mpa_rx.len_arr) *
> card->mp_agg_pkt_limit, GFP_KERNEL);
> + if (!card->mpa_rx.len_arr)
> + return -ENOMEM;
> +
> ret = mwifiex_alloc_sdio_mpa_buffers(adapter,
> card->mp_tx_agg_buf_size,
> card->mp_rx_agg_buf_size);

You can't just return, you have to release all of the resources
acquired above the point where the error happens.