From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
chris.park@atmel.com, austin.shin@atmel.com,
linux-wireless@vger.kernel.org, johnny.kim@atmel.com,
tony.cho@atmel.com, leo.kim@atmel.com
Subject: Re: [PATCH 3/3] staging: wilc1000: use int type for counter variable
Date: Tue, 19 Jan 2016 14:30:44 +0300 [thread overview]
Message-ID: <20160119113043.GA6370@mwanda> (raw)
In-Reply-To: <1453199177-21085-3-git-send-email-chaehyun.lim@gmail.com>
On Tue, Jan 19, 2016 at 07:26:17PM +0900, Chaehyun Lim wrote:
> counter is used as for-loop control variable and indicating index of
> struct wid array so that it is better to use int type.
> There is no need to set to 0 when it is declared at the top of this
> function. counter is initialized as 0 in for-loop statement.
>
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 86dfe77..7e8e423 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -591,7 +591,7 @@ s32 wilc_dealloc_assoc_resp_info(tstrConnectRespInfo *pstrConnectRespInfo)
> int wilc_send_config_pkt(struct wilc *wilc, u8 mode, struct wid *wids,
> u32 count, u32 drv)
> {
> - s32 counter = 0;
> + int counter;
rename it to "i" as well. "int i;"
regards,
dan carpenter
prev parent reply other threads:[~2016-01-19 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:26 [PATCH 1/3] staging: wilc1000: fix return type of wilc_send_config_pkt Chaehyun Lim
2016-01-19 10:26 ` [PATCH 2/3] staging: wilc1000: remove redundant initialization for counter variable Chaehyun Lim
2016-01-19 10:26 ` [PATCH 3/3] staging: wilc1000: use int type " Chaehyun Lim
2016-01-19 11:30 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119113043.GA6370@mwanda \
--to=dan.carpenter@oracle.com \
--cc=austin.shin@atmel.com \
--cc=chaehyun.lim@gmail.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox