From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sven Eckelmann <sven@open-mesh.com>,
linux-wireless@vger.kernel.org, thomas@net.t-labs.tu-berlin.de,
nbd@nbd.name
Subject: Re: [PATCH] mac80211: minstrel: Scale expected_throughput by 10
Date: Mon, 1 Feb 2016 20:58:53 +0800 [thread overview]
Message-ID: <20160201125853.GA12011@prodigo> (raw)
In-Reply-To: <1454331473.3211.3.camel@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]
On Mon, Feb 01, 2016 at 01:57:53PM +0100, Johannes Berg wrote:
> On Mon, 2016-02-01 at 13:56 +0100, Sven Eckelmann wrote:
> > On Monday 01 February 2016 13:30:37 Johannes Berg wrote:
> > > On Mon, 2016-02-01 at 13:24 +0100, Sven Eckelmann wrote:
> > > > The change from cur_tp to the function
> > > > minstrel_get_tp_avg/minstrel_ht_get_tp_avg changed the unit used
> > > > for
> > > > the
> > > > current throughtput. For example in minstrel_ht the correct
> > > > conversion between them would be:
> > > >
> > > > mrs->cur_tp / 10 == minstrel_ht_get_tp_avg(..).
> > > >
> > > > This factor 10 must also be included in the calculation of
> > > > minstrel_get_expected_throughput and
> > > > minstrel_ht_get_expected_throughput to
> > > > get similar results as before the change.
> > > >
> > >
> > > 10 is a pretty expensive factor, perhaps that should use 16
> > > instead?
> >
> > Not really funny but I will change the title.
>
> Huh? Not sure what you mean. I really meant to change 10 to 16 overall
> as far as the factor is concerned, since division by/multiplication
> with 16 is far easier in base 2 than by/with 10.
Should we first fix the bug introduced by 6a27b2c40b48 and then (with another
patch) improve this by changing the factor from 10 to 16 ?
The latter is going to be a bigger change because we need to make sure that the
value exported via station_info gets still scaled to kbps.
Cheers,
--
Antonio Quartulli
Director of Embedded Software | Open Mesh, Inc.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-01 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 12:24 [PATCH] mac80211: minstrel: Scale expected_throughput by 10 Sven Eckelmann
2016-02-01 12:30 ` Johannes Berg
2016-02-01 12:56 ` Sven Eckelmann
2016-02-01 12:57 ` Johannes Berg
2016-02-01 12:58 ` Antonio Quartulli [this message]
2016-02-01 13:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201125853.GA12011@prodigo \
--to=antonio@open-mesh.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sven@open-mesh.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).