From: Dan Carpenter <dan.carpenter@oracle.com>
To: huxm@marvell.com
Cc: linux-wireless@vger.kernel.org
Subject: re: mwifiex: enable pcie MSIx interrupt mode support
Date: Tue, 2 Feb 2016 13:00:34 +0300 [thread overview]
Message-ID: <20160202100034.GB3040@mwanda> (raw)
Hello Xinming Hu,
This is a semi-automatic email about new static checker warnings.
The patch 99074fc1e67b: "mwifiex: enable pcie MSIx interrupt mode
support" from Jan 11, 2016, leads to the following Smatch complaint:
drivers/net/wireless/marvell/mwifiex/pcie.c:2780 mwifiex_unregister_dev()
warn: variable dereferenced before check 'card' (see line 2777)
drivers/net/wireless/marvell/mwifiex/pcie.c
2776 const struct mwifiex_pcie_card_reg *reg;
2777 struct pci_dev *pdev = card->dev;
^^^^^^^^^
New dereference.
2778 int i;
2779
2780 if (card) {
^^^^
Old check.
2781 if (card->msix_enable) {
2782 for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
regards,
dan carpenter
reply other threads:[~2016-02-02 10:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202100034.GB3040@mwanda \
--to=dan.carpenter@oracle.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox