linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: mwifiex: enable pcie MSIx interrupt mode support
@ 2016-02-02 10:00 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-02-02 10:00 UTC (permalink / raw)
  To: huxm; +Cc: linux-wireless

Hello Xinming Hu,

This is a semi-automatic email about new static checker warnings.

The patch 99074fc1e67b: "mwifiex: enable pcie MSIx interrupt mode 
support" from Jan 11, 2016, leads to the following Smatch complaint:

drivers/net/wireless/marvell/mwifiex/pcie.c:2780 mwifiex_unregister_dev()
	 warn: variable dereferenced before check 'card' (see line 2777)

drivers/net/wireless/marvell/mwifiex/pcie.c
  2776		const struct mwifiex_pcie_card_reg *reg;
  2777		struct pci_dev *pdev = card->dev;
                                       ^^^^^^^^^
New dereference.

  2778		int i;
  2779	
  2780		if (card) {
                    ^^^^
Old check.

  2781			if (card->msix_enable) {
  2782				for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-02 10:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-02 10:00 mwifiex: enable pcie MSIx interrupt mode support Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).