From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Kim, Leo" <Leo.Kim@atmel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Park, Chris" <Chris.Park@atmel.com>,
"Shin, Austin" <Austin.Shin@atmel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"Cho, Tony" <Tony.Cho@atmel.com>,
"Abozaeid, Adham" <Adham.Abozaeid@atmel.com>
Subject: Re: [PATCH RESEND 04/10] staging: wilc1000: removes unnecessary wilc_debug print log
Date: Mon, 22 Feb 2016 17:44:25 +0300 [thread overview]
Message-ID: <20160222144424.GD5273@mwanda> (raw)
In-Reply-To: <74F3875218FC364C9618AB19CB60E9058004B81C@penmbx02.corp.atmel.com>
On Mon, Feb 22, 2016 at 11:42:42AM +0000, Kim, Leo wrote:
> Dear Dan,
>
> This patch is subject "removes unnecessary wilc_debug print log".
I'm fine with you fixing it up in a later patch, but you should not be defending
this patch as valid way to do things.
The rule is "do one thing at a time", not "do half a thing at a time."
In the original code the if statement was required because it was
determining when to print, but now it is a confusing unneeded line of
code. I'm not asking for an additional unrelated cleanup for something that was
already there in the original code. It was this patch which introduced
the problem (the stray unneeded line of code).
Also I had already asked you to redo this on Feb 19.
Part of the reason that we like people to "do one thing per patch" is that
people promise they will clean things up in the future but they get distracted
and forget.
regards,
dan carpenter
next prev parent reply other threads:[~2016-02-22 14:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 4:41 [PATCH RESEND 01/10] staging: wilc1000: removes wilc_dbg() Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 02/10] staging: wilc1000: replaces wilc_debug with netdev_err Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 03/10] staging: wilc1000: removes unnecessary wilc_debug print log Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 04/10] " Leo Kim
2016-02-22 10:45 ` Dan Carpenter
2016-02-22 11:42 ` Kim, Leo
2016-02-22 14:44 ` Dan Carpenter [this message]
2016-02-23 5:29 ` Kim, Leo
2016-02-22 4:41 ` [PATCH RESEND 05/10] staging: wilc1000: removes unnecessary variable of wilc_mac_cfg_t structure Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 06/10] staging: wilc1000: wilc_wlan_cfg_init: changes unused argument Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 07/10] staging: wilc1000: move WILC_MULTICAST_TABLE_SIZE define to wilc_wlan_if.h file Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 08/10] staging: wilc1000: move MODALIS and GPIO_NUM define to wilc_wlan.h file Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 09/10] staging: wilc1000: remove useless define in linux_wlan_common.h file Leo Kim
2016-02-22 4:41 ` [PATCH RESEND 10/10] staging: wilc1000: removes " Leo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222144424.GD5273@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Adham.Abozaeid@atmel.com \
--cc=Austin.Shin@atmel.com \
--cc=Chris.Park@atmel.com \
--cc=Leo.Kim@atmel.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=Tony.Cho@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).