* at76c50x-usb: usb_put_dev() if at76_load_internal_fw() succeed
@ 2016-02-20 22:30 Alexey Khoroshilov
2016-02-20 22:30 ` [PATCH] at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_probe() Alexey Khoroshilov
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Khoroshilov @ 2016-02-20 22:30 UTC (permalink / raw)
To: Kalle Valo
Cc: Alexey Khoroshilov, Andrea Merello, linux-wireless, linux-kernel,
ldv-project
I do not see any reason to call usb_put_dev() if at76_load_internal_fw() succeed.
But it is here from the very beginning. Any suggestions?
--
Thank you,
Alexey
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_probe()
2016-02-20 22:30 at76c50x-usb: usb_put_dev() if at76_load_internal_fw() succeed Alexey Khoroshilov
@ 2016-02-20 22:30 ` Alexey Khoroshilov
2016-03-07 12:24 ` at76c50x-usb: avoid double usb_put_dev() after downloading internalfirmware " Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Khoroshilov @ 2016-02-20 22:30 UTC (permalink / raw)
To: Kalle Valo
Cc: Alexey Khoroshilov, Andrea Merello, linux-wireless, linux-kernel,
ldv-project
There is no need in usb_put_dev() if at76_load_internal_fw() succeed.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/net/wireless/atmel/at76c50x-usb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
index dab25136214a..1efb1d66e0b7 100644
--- a/drivers/net/wireless/atmel/at76c50x-usb.c
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -2481,9 +2481,7 @@ static int at76_probe(struct usb_interface *interface,
dev_err(&interface->dev,
"error %d downloading internal firmware\n",
ret);
- goto exit;
}
- usb_put_dev(udev);
goto exit;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-07 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 22:30 at76c50x-usb: usb_put_dev() if at76_load_internal_fw() succeed Alexey Khoroshilov
2016-02-20 22:30 ` [PATCH] at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_probe() Alexey Khoroshilov
2016-03-07 12:24 ` at76c50x-usb: avoid double usb_put_dev() after downloading internalfirmware " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).