From: Samuel Ortiz <sameo@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-wireless@vger.kernel.org,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>
Subject: Re: [PATCH] NFC: microread: Drop platform data header file
Date: Wed, 9 Mar 2016 23:28:12 +0100 [thread overview]
Message-ID: <20160309222812.GA21618@zurbaran.home> (raw)
In-Reply-To: <20160121092012.0e0f73e1@endymion.delvare>
Hi Jean,
On Thu, Jan 21, 2016 at 09:20:12AM +0100, Jean Delvare wrote:
> Originally I only wanted to drop the unneeded inclusion of
> <linux/i2c.h>, but then noticed that struct
> microread_nfc_platform_data isn't actually used, and
> MICROREAD_DRIVER_NAME is redefined in the only file where it is used,
> so we can get rid of the header file and dead code altogether.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Eric Lapuyade <eric.lapuyade@intel.com>
> Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>
> Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> Makes me wonder if this driver is used at all? I can't see any
> instance in the kernel tree.
The mei part of it is used.
> MAINTAINERS | 1
> drivers/nfc/microread/i2c.c | 8 -------
> include/linux/platform_data/microread.h | 35 --------------------------------
> 3 files changed, 44 deletions(-)
Applied, thanks.
Cheers,
Samuel.
prev parent reply other threads:[~2016-03-09 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 8:20 [PATCH] NFC: microread: Drop platform data header file Jean Delvare
2016-01-21 8:47 ` Jean Delvare
2016-03-09 22:28 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309222812.GA21618@zurbaran.home \
--to=sameo@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=jdelvare@suse.de \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox