From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Vishal Thanki <vishalthanki@gmail.com>
Cc: helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rt2x00usb: Use usb anchors to manage URB
Date: Thu, 17 Mar 2016 09:43:32 +0100 [thread overview]
Message-ID: <20160317084331.GA19458@redhat.com> (raw)
In-Reply-To: <1458149331-2106-1-git-send-email-vishalthanki@gmail.com>
Hi
On Wed, Mar 16, 2016 at 06:28:51PM +0100, Vishal Thanki wrote:
> +struct rt2x00usb_anchors {
> + struct usb_anchor async_urb;
> + struct usb_anchor tx_submitted;
> + struct usb_anchor rx_submitted;
> +};
I don't think we need 3 different usb_anchor's, one should be
enough.
> +static struct rt2x00usb_anchors *anchors;
usb_anchor structure should be embedded in rt2x00_dev structure,
otherwise you can kill urb's from other rt2x00 devices, when
disconnecting another one.
Stanislaw
next prev parent reply other threads:[~2016-03-17 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:28 [PATCH] rt2x00usb: Use usb anchors to manage URB Vishal Thanki
2016-03-17 8:43 ` Stanislaw Gruszka [this message]
2016-03-17 9:53 ` Vishal Thanki
2016-03-17 11:28 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317084331.GA19458@redhat.com \
--to=sgruszka@redhat.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vishalthanki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).