Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

[Vishal Thanki <vishalthanki@gmail.com>]

Hi,

On Thu, Mar 17, 2016 at 09:43:32AM +0100, Stanislaw Gruszka wrote:
> Hi
> 
> On Wed, Mar 16, 2016 at 06:28:51PM +0100, Vishal Thanki wrote:
> > +struct rt2x00usb_anchors {
> > +	struct usb_anchor async_urb;
> > +	struct usb_anchor tx_submitted;
> > +	struct usb_anchor rx_submitted;
> > +};
> 
> I don't think we need 3 different usb_anchor's, one should be
> enough.
> 

Ok, I will change that.

> > +static struct rt2x00usb_anchors *anchors;
> 
> usb_anchor structure should be embedded in rt2x00_dev structure,
> otherwise you can kill urb's from other rt2x00 devices, when
> disconnecting another one.
> 

rt2x00_dev structure does not contain any bus specific data structures
(for example no structures present for USB/PCI). Should I add a void
*ptr in rt2x00_dev and cast it as usb_anchor in rt2x00usb.c?

Thanks,
Vishal

> Stanislaw