Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

[Mohammed Shafi Shajakhan <mohammed@codeaurora.org>]

Hi Michal,

On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote:
> On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan
> <mohammed@qti.qualcomm.com> wrote:
> [...]
> > +void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
> > +                          struct ieee80211_sta *sta,
> > +                          struct station_info *sinfo)
> > +{
> > +       struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
> > +       struct ath10k *ar = arsta->arvif->ar;
> > +
> > +       mutex_lock(&ar->conf_mutex);
> > +
> > +       if (ar->state != ATH10K_STATE_ON &&
> > +           ar->state != ATH10K_STATE_RESTARTED)
> > +               goto out;
> 
> Do you really need mutex and ar->state check in this function?
>

[shafi] By default peer stats will be disabled, we are enabling this by debugfs
(hw-restart) so i thought these checks are needed , please advise .. Do you say
they  will be never hit 

regards
shafi