From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Johannes Berg <johannes.berg@intel.com>,
Jia-Ju Bai <baijiaju1990@163.com>,
Sara Sharon <sarasharon1@gmail.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up
Date: Fri, 18 Mar 2016 12:22:13 +0100 [thread overview]
Message-ID: <20160318112212.GF24990@redhat.com> (raw)
In-Reply-To: <CAGRGNgVh+-UOMVmo98HMashUi3CejdXTx4S=sTxq8VcNNrWeag@mail.gmail.com>
On Fri, Mar 18, 2016 at 10:12:34PM +1100, Julian Calaby wrote:
> I don't think you're right. Looking closely at the code,
> il->num_stations gets incremented in il_prep_station() which is called
> unconditionally from il4965_alloc_bcast_station().
>
> So I think this and the following patch are fine.
You have right.
Thanks
Stanislaw
next prev parent reply other threads:[~2016-03-18 11:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 2:20 [PATCH 00/19] Pending Cleanup patches for 4.7 Julian Calaby
2016-03-18 2:16 ` [PATCH 01/19] ath9k: Remove unnecessary ?: operator Julian Calaby
2016-04-07 16:38 ` [01/19] " Kalle Valo
2016-03-18 2:20 ` [PATCH 02/19] ipw2x00: use to_pci_dev() Julian Calaby
2016-03-24 22:28 ` Stanislav Yakovlev
2016-03-18 2:21 ` [PATCH 03/19] wlcore: use to_delayed_work() Julian Calaby
2016-03-18 2:22 ` [PATCH 04/19] wl1251: " Julian Calaby
2016-03-18 2:22 ` [PATCH 05/19] rtlwifi: " Julian Calaby
2016-03-18 2:44 ` Larry Finger
2016-03-18 2:22 ` [PATCH 06/19] ath9k_htc: Delete unnecessary variable initialisation Julian Calaby
2016-03-18 2:23 ` [PATCH 07/19] brcmfmac: " Julian Calaby
2016-03-18 2:23 ` [PATCH 08/19] iwlegacy: Return directly if allocation fails in il_eeprom_init() Julian Calaby
2016-03-18 13:41 ` SF Markus Elfring
2016-03-18 14:33 ` Julian Calaby
2016-03-18 14:53 ` Dan Carpenter
2016-03-19 13:16 ` Julian Calaby
2016-03-18 2:24 ` [PATCH 09/19] iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_free Julian Calaby
2016-03-18 2:24 ` [PATCH 10/19] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init Julian Calaby
2016-03-18 2:24 ` [PATCH 11/19] rtl818x_pci: Disable pci device in error handling code Julian Calaby
2016-03-18 2:25 ` [PATCH DETAIL 12/19] rsi: Delete unnecessary variable initialisation Julian Calaby
2016-03-18 2:25 ` [PATCH DETAIL 13/19] " Julian Calaby
2016-03-19 12:27 ` SF Markus Elfring
2016-03-19 13:15 ` Julian Calaby
2016-03-18 2:27 ` [PATCH MOREWORK 14/19] rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring Julian Calaby
2016-04-08 1:38 ` Julian Calaby
[not found] ` <CAN8YU5OqKhqaucUs04Xe3wT8D1_p3B8miWKDQLv-aGakr12ZWA@mail.gmail.com>
2016-04-11 0:11 ` Julian Calaby
2016-04-12 21:13 ` Andrea Merello
2016-04-26 9:08 ` [MOREWORK, " Kalle Valo
2016-03-18 2:27 ` [PATCH MOREWORK 15/19] rsi: Move variable initialisation into error code Julian Calaby
2016-03-18 2:28 ` [PATCH MOREWORK 16/19] rtlwifi: Implement 'rtl_addr_delay()' with a switch statement Julian Calaby
2016-03-18 2:38 ` Larry Finger
2016-03-18 3:32 ` Julian Calaby
2016-03-18 2:28 ` [PATCH MOREWORK 17/19] iwl4965: Fix a memory leak in error handling code of __il4965_up Julian Calaby
2016-03-18 10:48 ` Stanislaw Gruszka
2016-03-18 11:12 ` Julian Calaby
2016-03-18 11:22 ` Stanislaw Gruszka [this message]
2016-03-18 2:29 ` [PATCH MOREWORK 18/19] iwl4965: Fix more memory leaks in __il4965_up() Julian Calaby
2016-03-18 10:53 ` Stanislaw Gruszka
2016-03-21 13:28 ` Stanislaw Gruszka
2016-03-18 2:29 ` [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init() Julian Calaby
2016-03-18 10:31 ` Stanislaw Gruszka
2016-03-18 10:42 ` Julian Calaby
2016-03-18 11:01 ` Dan Carpenter
2016-03-18 11:14 ` Julian Calaby
2016-04-07 12:07 ` [PATCH 00/19] Pending Cleanup patches for 4.7 Kalle Valo
2016-04-07 16:37 ` Kalle Valo
2016-04-08 0:56 ` Julian Calaby
2016-04-08 1:35 ` Julian Calaby
2016-04-15 12:04 ` Kalle Valo
2016-04-15 11:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318112212.GF24990@redhat.com \
--to=sgruszka@redhat.com \
--cc=baijiaju1990@163.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=julian.calaby@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sarasharon1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).