From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Vishal Thanki <vishalthanki@gmail.com>
Cc: helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5] rt2x00usb: Use usb anchor to manage URB
Date: Sat, 19 Mar 2016 09:06:28 +0100 [thread overview]
Message-ID: <20160319080627.GA29771@redhat.com> (raw)
In-Reply-To: <1458318591-14921-1-git-send-email-vishalthanki@gmail.com>
On Fri, Mar 18, 2016 at 05:29:51PM +0100, Vishal Thanki wrote:
>
> @@ -1001,6 +1002,9 @@ struct rt2x00_dev {
>
> /* Extra TX headroom required for alignment purposes. */
> unsigned int extra_tx_headroom;
> +
> + struct usb_anchor *anchor;
> + void (*kill_anchored_urbs)(struct rt2x00_dev *);
...
> @@ -1423,6 +1423,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> cancel_delayed_work_sync(&rt2x00dev->autowakeup_work);
> cancel_work_sync(&rt2x00dev->sleep_work);
> if (rt2x00_is_usb(rt2x00dev)) {
> + rt2x00dev->kill_anchored_urbs(rt2x00dev);
...
>
> +static void rt2x00usb_kill_anchored_usb(struct rt2x00_dev *rt2x00dev)
> +{
> + usb_kill_anchored_urbs(rt2x00dev->anchor);
> +}
...
> + rt2x00dev->kill_anchored_urbs = rt2x00usb_kill_anchored_usb;
Why do you complicate things, instead of call usb_kill_anchored_urbs()
directly?
Stanislaw
next prev parent reply other threads:[~2016-03-19 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 16:29 [PATCH v5] rt2x00usb: Use usb anchor to manage URB Vishal Thanki
2016-03-19 8:06 ` Stanislaw Gruszka [this message]
2016-03-19 8:21 ` Vishal Thanki
2016-03-19 8:58 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160319080627.GA29771@redhat.com \
--to=sgruszka@redhat.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vishalthanki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).