From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [1/2] bcma: fix building without OF_IRQ
Date: Wed, 23 Mar 2016 15:52:43 +0000 (UTC) [thread overview]
Message-ID: <20160323155243.D408161506@smtp.codeaurora.org> (raw)
In-Reply-To: <1458206432-3039552-1-git-send-email-arnd@arndb.de>
> The bcma driver core can be built with or without DT support, but
> it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which
> can happen on platforms that do not support IRQ domains.
>
> ERROR: "irq_create_of_mapping" [drivers/bcma/bcma.ko] undefined!
> ERROR: "of_irq_parse_raw" [drivers/bcma/bcma.ko] undefined!
> ERROR: "of_irq_parse_one" [drivers/bcma/bcma.ko] undefined!
>
> This adds another compile-time check for OF_IRQ, but also
> gets rid of now unneeded #ifdef checks: Using the simpler
> IS_ENABLED() check for OF_IRQ also covers the case of not
> having CONFIG_OF enabled. The check for CONFIG_OF_ADDRESS
> was added to allow building on architectures without
> OF_ADDRESS, but that has been addressed already in
> b1d06b60e90c ("of: Provide static inline function for
> of_translate_address if needed").
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied to wireless-drivers.git.
Kalle Valo
next prev parent reply other threads:[~2016-03-23 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:20 [PATCH 1/2] bcma: fix building without OF_IRQ Arnd Bergmann
2016-03-17 9:20 ` [PATCH 2/2] bcma: use of_dma_configure() to set initial dma mask Arnd Bergmann
2016-03-17 9:22 ` Arnd Bergmann
2016-03-17 9:43 ` kbuild test robot
2016-03-23 15:52 ` Kalle Valo [this message]
[not found] <20160323155243.D1AB4615C6@smtp.codeaurora.org>
2016-03-24 13:19 ` [1/2] bcma: fix building without OF_IRQ Arnd Bergmann
2016-03-24 13:53 ` Kalle Valo
2016-03-24 14:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323155243.D408161506@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).