From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:49613 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754563AbcDKMZ5 (ORCPT ); Mon, 11 Apr 2016 08:25:57 -0400 Date: Mon, 11 Apr 2016 15:24:47 +0300 From: Dan Carpenter To: Alison Schofield Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chris Park , Austin Shin , Greg Kroah-Hartman , Johnny Kim , linux-kernel@vger.kernel.org, Tony Cho , Leo Kim Subject: Re: [PATCH] staging: wilc1000: move initialization of the config values Message-ID: <20160411122447.GE4298@mwanda> (sfid-20160411_142635_474731_54D46240) References: <20160408053515.GA10278@d830.WORKGROUP> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160408053515.GA10278@d830.WORKGROUP> Sender: linux-wireless-owner@vger.kernel.org List-ID: That may work, but I think it would be simpler to do this next to the kzalloc() before we do the wilc->vif[i]->hif_drv = hif_drv; assignment. regards, dan carpenter