From: Bob Copeland <me@bobcopeland.com>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
kvalo@codeaurora.org, lkml2017@openmailbox.org
Subject: Re: [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation
Date: Sat, 16 Apr 2016 10:53:14 -0400 [thread overview]
Message-ID: <20160416145314.GB2894@localhost> (raw)
In-Reply-To: <5711D557.6000803@rempel-privat.de>
On Sat, Apr 16, 2016 at 08:01:59AM +0200, Oleksij Rempel wrote:
> > For a future patch, "sizeof(mask_m)" or even just:
> >
> > u8 mask_m[123] = {0};
> >
> > ... would be better here. I looked at this bit and thought, no way is
> > "123" actually correct. Lo and behold, that is actually the number of
> > array elements, whether that has a basis in something real or not :)
>
> If you already on it can you please rework it on top of this patch?
> This complete function can be probably reworked.
I wasn't on it, but yeah I'll send a patch on top of this momentarily :)
--
Bob Copeland %% http://bobcopeland.com/
prev parent reply other threads:[~2016-04-16 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 22:24 [PATCH] Revert regression in ath9k on AR9281 lkml2017
2016-04-08 0:53 ` Julian Calaby
2016-04-11 2:28 ` Gustav Frederiksen
2016-04-11 19:04 ` Oleksij Rempel
2016-04-12 1:53 ` Gustav Frederiksen
2016-04-12 17:37 ` [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation Oleksij Rempel
2016-04-13 9:41 ` Kalle Valo
2016-04-13 9:45 ` Kalle Valo
2016-04-13 16:45 ` Oleksij Rempel
2016-04-15 18:05 ` ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_pinitialisation Kalle Valo
2016-04-15 20:59 ` [PATCH] ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p initialisation Bob Copeland
2016-04-16 6:01 ` Oleksij Rempel
2016-04-16 14:53 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416145314.GB2894@localhost \
--to=me@bobcopeland.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=lkml2017@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).