* [patch 1/2] mwifiex: missing error code on allocation failure
@ 2016-04-19 14:21 Dan Carpenter
2016-04-26 9:29 ` [1/2] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-04-19 14:21 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: Nishant Sarmukadam, Kalle Valo, linux-wireless, kernel-janitors
We accidentally return success instead of -ENOMEM.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c b/drivers/net/wireless/marvell/mwifiex/usb.c
index 0510861..cdd8f9a 100644
--- a/drivers/net/wireless/marvell/mwifiex/usb.c
+++ b/drivers/net/wireless/marvell/mwifiex/usb.c
@@ -1017,8 +1017,10 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
/* Allocate memory for receive */
recv_buff = kzalloc(FW_DNLD_RX_BUF_SIZE, GFP_KERNEL);
- if (!recv_buff)
+ if (!recv_buff) {
+ ret = -ENOMEM;
goto cleanup;
+ }
do {
/* Send pseudo data to check winner status first */
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-26 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-19 14:21 [patch 1/2] mwifiex: missing error code on allocation failure Dan Carpenter
2016-04-26 9:29 ` [1/2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).