* [PATCH] rt2800usb: enable MFP if hw crypt is disabled
@ 2016-04-20 6:59 Chun-Yeow Yeoh
2016-04-20 16:04 ` Stanislaw Gruszka
0 siblings, 1 reply; 3+ messages in thread
From: Chun-Yeow Yeoh @ 2016-04-20 6:59 UTC (permalink / raw)
To: linux-wireless; +Cc: sgruszka, helmut.schaa, kvalo, Chun-Yeow Yeoh
If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
care of the crypto with software encryption/decryption
and thus, MFP can be used.
Tested for secured mesh using ath9k_htc and ath9k.
Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
---
drivers/net/wireless/ralink/rt2x00/rt2800usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800usb.c b/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
index 4b0bb6b..84ea329 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
@@ -48,6 +48,7 @@ MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
static bool rt2800usb_hwcrypt_disabled(struct rt2x00_dev *rt2x00dev)
{
+ ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
return modparam_nohwcrypt;
}
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rt2800usb: enable MFP if hw crypt is disabled
2016-04-20 6:59 [PATCH] rt2800usb: enable MFP if hw crypt is disabled Chun-Yeow Yeoh
@ 2016-04-20 16:04 ` Stanislaw Gruszka
2016-04-20 16:42 ` Yeoh Chun-Yeow
0 siblings, 1 reply; 3+ messages in thread
From: Stanislaw Gruszka @ 2016-04-20 16:04 UTC (permalink / raw)
To: Chun-Yeow Yeoh; +Cc: linux-wireless, helmut.schaa, kvalo
On Wed, Apr 20, 2016 at 02:59:32PM +0800, Chun-Yeow Yeoh wrote:
> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
> care of the crypto with software encryption/decryption
> and thus, MFP can be used.
>
> Tested for secured mesh using ath9k_htc and ath9k.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800usb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800usb.c b/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
> index 4b0bb6b..84ea329 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
> @@ -48,6 +48,7 @@ MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
>
> static bool rt2800usb_hwcrypt_disabled(struct rt2x00_dev *rt2x00dev)
> {
> + ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
> return modparam_nohwcrypt;
You set MFP feature regardless if actually hwcrypt is disabled or not.
Beside this should not be done in function which is intended to test
if hw crypto is disabled. Please set the future in place where other
hw->flags are set.
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rt2800usb: enable MFP if hw crypt is disabled
2016-04-20 16:04 ` Stanislaw Gruszka
@ 2016-04-20 16:42 ` Yeoh Chun-Yeow
0 siblings, 0 replies; 3+ messages in thread
From: Yeoh Chun-Yeow @ 2016-04-20 16:42 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: linux-wireless@vger.kernel.org, Helmut Schaa, Kalle Valo
Noted. Patch v2 sent.
----
Chun-Yeow
On Thu, Apr 21, 2016 at 12:04 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> On Wed, Apr 20, 2016 at 02:59:32PM +0800, Chun-Yeow Yeoh wrote:
>> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
>> care of the crypto with software encryption/decryption
>> and thus, MFP can be used.
>>
>> Tested for secured mesh using ath9k_htc and ath9k.
>>
>> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
>> ---
>> drivers/net/wireless/ralink/rt2x00/rt2800usb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800usb.c b/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
>> index 4b0bb6b..84ea329 100644
>> --- a/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
>> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800usb.c
>> @@ -48,6 +48,7 @@ MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
>>
>> static bool rt2800usb_hwcrypt_disabled(struct rt2x00_dev *rt2x00dev)
>> {
>> + ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
>> return modparam_nohwcrypt;
>
> You set MFP feature regardless if actually hwcrypt is disabled or not.
> Beside this should not be done in function which is intended to test
> if hw crypto is disabled. Please set the future in place where other
> hw->flags are set.
>
> Thanks
> Stanislaw
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-20 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 6:59 [PATCH] rt2800usb: enable MFP if hw crypt is disabled Chun-Yeow Yeoh
2016-04-20 16:04 ` Stanislaw Gruszka
2016-04-20 16:42 ` Yeoh Chun-Yeow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).