linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled
@ 2016-04-20 16:41 Chun-Yeow Yeoh
  2016-04-21  9:16 ` Stanislaw Gruszka
  2016-04-26  9:31 ` [v2] " Kalle Valo
  0 siblings, 2 replies; 4+ messages in thread
From: Chun-Yeow Yeoh @ 2016-04-20 16:41 UTC (permalink / raw)
  To: linux-wireless; +Cc: sgruszka, helmut.schaa, kvalo, Chun-Yeow Yeoh

If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
care of the crypto with software encryption/decryption
and thus, MFP can be used.

Tested for secured mesh using ath9k_htc and ath9k.

Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>

v2: set MFP correctly (Stanislaw Gruszka)
---
 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 7fa0128..716468a 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -7492,6 +7492,10 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
 	if (!rt2x00_is_usb(rt2x00dev))
 		ieee80211_hw_set(rt2x00dev->hw, HOST_BROADCAST_PS_BUFFERING);
 
+	/* Set MFP if HW crypto is disabled. */
+	if (rt2800_hwcrypt_disabled(rt2x00dev))
+		ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
+
 	SET_IEEE80211_DEV(rt2x00dev->hw, rt2x00dev->dev);
 	SET_IEEE80211_PERM_ADDR(rt2x00dev->hw,
 				rt2800_eeprom_addr(rt2x00dev,
-- 
2.3.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled
  2016-04-20 16:41 [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled Chun-Yeow Yeoh
@ 2016-04-21  9:16 ` Stanislaw Gruszka
  2016-04-26  9:31 ` [v2] " Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Stanislaw Gruszka @ 2016-04-21  9:16 UTC (permalink / raw)
  To: Chun-Yeow Yeoh; +Cc: linux-wireless, helmut.schaa, kvalo

On Thu, Apr 21, 2016 at 12:41:34AM +0800, Chun-Yeow Yeoh wrote:
> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
> care of the crypto with software encryption/decryption
> and thus, MFP can be used.
> 
> Tested for secured mesh using ath9k_htc and ath9k.
> 
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>

Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [v2] rt2800lib: enable MFP if hw crypt is disabled
  2016-04-20 16:41 [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled Chun-Yeow Yeoh
  2016-04-21  9:16 ` Stanislaw Gruszka
@ 2016-04-26  9:31 ` Kalle Valo
  2016-04-26  9:39   ` Kalle Valo
  1 sibling, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2016-04-26  9:31 UTC (permalink / raw)
  To: Chun-Yeow Yeoh
  Cc: linux-wireless, sgruszka, helmut.schaa, kvalo, Chun-Yeow Yeoh


> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
> care of the crypto with software encryption/decryption
> and thus, MFP can be used.
> 
> Tested for secured mesh using ath9k_htc and ath9k.
> 
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
> 
> v2: set MFP correctly (Stanislaw Gruszka)
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [v2] rt2800lib: enable MFP if hw crypt is disabled
  2016-04-26  9:31 ` [v2] " Kalle Valo
@ 2016-04-26  9:39   ` Kalle Valo
  0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2016-04-26  9:39 UTC (permalink / raw)
  To: Chun-Yeow Yeoh; +Cc: linux-wireless, sgruszka, helmut.schaa

Kalle Valo <kvalo@codeaurora.org> writes:

>> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
>> care of the crypto with software encryption/decryption
>> and thus, MFP can be used.
>> 
>> Tested for secured mesh using ath9k_htc and ath9k.
>> 
>> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
>> 
>> v2: set MFP correctly (Stanislaw Gruszka)
>> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Thanks, applied to wireless-drivers-next.git.

Afterwards I edited out the change log from the commit log. Add that
after the "---" line so that git won't include it.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-04-26  9:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 16:41 [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled Chun-Yeow Yeoh
2016-04-21  9:16 ` Stanislaw Gruszka
2016-04-26  9:31 ` [v2] " Kalle Valo
2016-04-26  9:39   ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).