* [PATCH v2] mwifiex: fw download does not release sdio bus during failure
@ 2016-04-20 4:20 Marty Faltesek
2016-04-21 1:36 ` Julian Calaby
2016-04-27 13:50 ` [v2] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Marty Faltesek @ 2016-04-20 4:20 UTC (permalink / raw)
To: linux-wireless; +Cc: akarwar
Signed-off-by: Marty Faltesek <mfaltesek@google.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 4c8cae6..d6ef34f 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1026,13 +1026,12 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
offset += txlen;
} while (true);
- sdio_release_host(card->func);
-
mwifiex_dbg(adapter, MSG,
"info: FW download over, size %d bytes\n", offset);
ret = 0;
done:
+ sdio_release_host(card->func);
kfree(fwbuf);
return ret;
}
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mwifiex: fw download does not release sdio bus during failure
2016-04-20 4:20 [PATCH v2] mwifiex: fw download does not release sdio bus during failure Marty Faltesek
@ 2016-04-21 1:36 ` Julian Calaby
2016-04-27 13:50 ` [v2] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Julian Calaby @ 2016-04-21 1:36 UTC (permalink / raw)
To: Marty Faltesek; +Cc: linux-wireless, Amitkumar Karwar
Hi All,
On Wed, Apr 20, 2016 at 2:20 PM, Marty Faltesek <mfaltesek@google.com> wrote:
> Signed-off-by: Marty Faltesek <mfaltesek@google.com>
This looks right to me.
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks,
Julian Calaby
> ---
> drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
> index 4c8cae6..d6ef34f 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sdio.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> @@ -1026,13 +1026,12 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
> offset += txlen;
> } while (true);
>
> - sdio_release_host(card->func);
> -
> mwifiex_dbg(adapter, MSG,
> "info: FW download over, size %d bytes\n", offset);
>
> ret = 0;
> done:
> + sdio_release_host(card->func);
> kfree(fwbuf);
> return ret;
> }
> --
> 2.8.0.rc3.226.g39d4020
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] mwifiex: fw download does not release sdio bus during failure
2016-04-20 4:20 [PATCH v2] mwifiex: fw download does not release sdio bus during failure Marty Faltesek
2016-04-21 1:36 ` Julian Calaby
@ 2016-04-27 13:50 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-04-27 13:50 UTC (permalink / raw)
To: Marty Faltesek; +Cc: linux-wireless, akarwar
> Signed-off-by: Marty Faltesek <mfaltesek@google.com>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-27 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 4:20 [PATCH v2] mwifiex: fw download does not release sdio bus during failure Marty Faltesek
2016-04-21 1:36 ` Julian Calaby
2016-04-27 13:50 ` [v2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).