From: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
To: greearb@candelatech.com
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer.
Date: Tue, 10 May 2016 12:42:14 +0530 [thread overview]
Message-ID: <20160510071214.GD25626@atheros-ThinkPad-T61> (raw)
In-Reply-To: <1459545132-11295-3-git-send-email-greearb@candelatech.com>
Hi Ben,
On Fri, Apr 01, 2016 at 02:12:10PM -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> Not sure this can happen, but seems like a reasonable sanity
> check.
[shafi] possibly if the peer is removed and the bit is not cleared in the driver
? when the new peer occupies the slot
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> drivers/net/wireless/ath/ath10k/txrx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/txrx.c b/drivers/net/wireless/ath/ath10k/txrx.c
> index a779a4e..2edef8a 100644
> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -309,6 +309,7 @@ void ath10k_peer_map_event(struct ath10k_htt *htt,
> ath10k_warn(ar, /*ATH10K_DBG_HTT,*/ "htt peer map vdev %d peer %pM id %d\n",
> ev->vdev_id, ev->addr, ev->peer_id);
>
> + WARN_ON(ar->peer_map[ev->peer_id] && (ar->peer_map[ev->peer_id] != peer));
> ar->peer_map[ev->peer_id] = peer;
> set_bit(ev->peer_id, peer->peer_ids);
> exit:
> --
> 2.4.3
regards,
shafi
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-05-10 7:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 21:12 [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx greearb
2016-04-01 21:12 ` [PATCH v2 2/5] ath10k: Ensure peer_map references are cleaned up greearb
2016-04-01 21:12 ` [PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer greearb
2016-05-10 7:12 ` Mohammed Shafi Shajakhan [this message]
2016-05-10 14:41 ` Ben Greear
2016-05-10 16:38 ` Mohammed Shafi Shajakhan
2016-07-08 6:48 ` [v2,3/5] " Kalle Valo
2016-04-01 21:12 ` [PATCH v2 4/5] ath10k: Clean up peer when sta goes away greearb
2016-04-01 21:12 ` [PATCH v2 5/5] ath10k: Fix deadlock when peer cannot be created greearb
2016-05-09 17:19 ` Ben Greear
2016-05-09 17:54 ` Manoharan, Rajkumar
2016-05-09 17:58 ` Ben Greear
2016-05-13 14:07 ` Valo, Kalle
2016-06-06 17:24 ` [v2,5/5] " Kalle Valo
2016-05-10 6:48 ` [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx Mohammed Shafi Shajakhan
2016-05-10 14:39 ` Ben Greear
2016-05-10 16:36 ` Mohammed Shafi Shajakhan
2016-07-08 6:43 ` [v2, " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510071214.GD25626@atheros-ThinkPad-T61 \
--to=mohammed@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox